Skip to content

Fix duplicate declaration error on ambient class declarations#14016

Merged
nicolo-ribaudo merged 3 commits into
babel:mainfrom
The-x-Theorist:duplicate-declaration-bug
Dec 5, 2021
Merged

Fix duplicate declaration error on ambient class declarations#14016
nicolo-ribaudo merged 3 commits into
babel:mainfrom
The-x-Theorist:duplicate-declaration-bug

Conversation

@The-x-Theorist

@The-x-Theorist The-x-Theorist commented Dec 2, 2021

Copy link
Copy Markdown
Contributor
Q                       A
Fixed Issues? Fixes #13735
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Improve the scope handling for declare class by adding a check using path.node.declare for "declare class".

@babel-bot

babel-bot commented Dec 2, 2021

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50140/

Comment thread packages/babel-traverse/src/scope/index.ts
@The-x-Theorist The-x-Theorist force-pushed the duplicate-declaration-bug branch from 6612831 to b48b880 Compare December 4, 2021 07:21
@JLHwung JLHwung changed the title Fix duplicate declaration error Fix duplicate declaration error on ambient class declarations Dec 5, 2021
@nicolo-ribaudo nicolo-ribaudo added pkg: traverse (scope) PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Dec 5, 2021

@nicolo-ribaudo nicolo-ribaudo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit a943f57 into babel:main Dec 5, 2021
@The-x-Theorist The-x-Theorist deleted the duplicate-declaration-bug branch December 6, 2021 06:41
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 8, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse (scope) PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error when I specify "declare class" and "function" with the same name

4 participants