Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amareshsm
added
the
accepted
amareshsm
reviewed
Jul 26, 2023
snitin315
reviewed
Jul 27, 2023
snitin315
previously approved these changes
Jul 27, 2023
Co-authored-by: Amaresh S M <amareshsm13@gmail.com>
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
Member
Author
|
Ah, it looks like the linting error is actually the link checker. Maybe we should run that as a separate CI job to avoid confusion? |
Contributor
I think it's fine, we anyway need to install deps and build the website to run the link checker. |
eslint-github-bot
Bot
added
the
archived due to age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Infrastructure
What changes did you make? (Give an overview)
Adds PRs to the triage project so we can manage issues and PRs in one place.
I also updated the triaging documentation to explicitly mention pull requests.
Related PRs:
Is there anything you'd like reviewers to focus on?
Does the documentation make sense.