This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients elixir, loewis, pitrou, python-dev, vstinner
Date 2013-11-08.14:13:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAMpsgwa+yEyUXU7VYxpA1TbXv_JmWPkNeV1nKqH9F__4Sze5-w@mail.gmail.com>
In-reply-to <1383918305.11.0.767019652209.issue19515@psf.upfronthosting.co.za>
Content
2013/11/8 Martin v. Löwis <report@bugs.python.org>:
> I'd be +0 on extracting common identifiers. I (...) expect a slight reduction of memory usage, and a tiny reduction in runtime.

Only duplicated Py_IDENTIFIER structures would be removed in memory,
but these structures are very small (3 pointers or something like
that). The identifier strings are already interned, so not duplicated
in memory.

> It's not really worth the effort, but I fail to see that it causes harm.

Initializing an identifier has to decode the literal byte string from
UTF-8, but Python UTF-8 decoder is really fast. I'm not sure that it's
possible to see a difference on the startup time.

> I see no point in reverting cases where this approach is already taken.

I only reverted shared identifiers added a few days ago in issue
#19512. I agree to leave the old code unchanged.

> I don't quite understand Victor's interest in this, either, as there are hundreds of open real bugs that could use his attention.

I tried to explain my motivation on using more identifiers in the issue #19512.
History
Date User Action Args
2013-11-08 14:13:33vstinnersetrecipients: + vstinner, loewis, pitrou, python-dev, elixir
2013-11-08 14:13:33vstinnerlinkissue19515 messages
2013-11-08 14:13:32vstinnercreate