Message 217341 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	jesstess
Recipients	amaury.forgeotdarc, bbrazil, belopolsky, jesstess, meador.inge
Date	2014-04-28.04:03:29
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1398657809.62.0.248634134193.issue13096@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for the report and patch, meador.inge. I'd prefer not to add more globals that are only used in one place, but doing so is consistent with the existing style of test_pointers.py, and there's plenty in this file that could be cleaned up in another ticket. * The patch passes `make patchcheck`. * The full test suite passes with this patch. * The reproducers in this issue segfault for me without this patch and do not segfault with this patch. lgtm! => commit review

Thanks for the report and patch, meador.inge.

I'd prefer not to add more globals that are only used in one place, but doing so is consistent with the existing style of test_pointers.py, and there's plenty in this file that could be cleaned up in another ticket.

* The patch passes `make patchcheck`.
* The full test suite passes with this patch.
* The reproducers in this issue segfault for me without this patch and do not segfault with this patch.

lgtm!

=> commit review

History
Date	User	Action	Args
2014-04-28 04:03:29	jesstess	set	recipients: + jesstess, amaury.forgeotdarc, belopolsky, meador.inge, bbrazil
2014-04-28 04:03:29	jesstess	set	messageid: <1398657809.62.0.248634134193.issue13096@psf.upfronthosting.co.za>
2014-04-28 04:03:29	jesstess	link	issue13096 messages
2014-04-28 04:03:29	jesstess	create