Message 224619 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	rpetrov
Recipients	BreamoreBoy, Nicholas.DiPiazza, Scott.Rostrup, jbinder, jlt63, rpetrov, stutzbach
Date	2014-08-03.08:31:05
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1407054665.25.0.379196336147.issue8548@psf.upfronthosting.co.za>
In-reply-to

Content
Hi Mark, #else before is not solution. See unified diff below as post by Scott Rostrup lack definition Some additional information: a) move outside #ifdef HAVE_FCNTL_H : definition PATH_MAX is not related to control functions on open files (fcntl.h) b) HAVE_FCNTL_H is defined for MSC build as well. so no impact on other build --- a/Modules/main.c +++ b/Modules/main.c @@ -9,6 +9,8 @@ #include <windows.h> #ifdef HAVE_FCNTL_H #include <fcntl.h> +#endif +#ifndef PATH_MAX #define PATH_MAX MAXPATHLEN #endif #endif --

Hi Mark,
#else before is not solution. See  unified diff below as post by Scott Rostrup lack definition

Some additional information:
a) move outside #ifdef HAVE_FCNTL_H : definition PATH_MAX is not related to control functions on open files (fcntl.h)
b) HAVE_FCNTL_H is defined for MSC build as well. so no impact on other build

--- a/Modules/main.c
+++ b/Modules/main.c
@@ -9,6 +9,8 @@
 #include <windows.h>
 #ifdef HAVE_FCNTL_H
 #include <fcntl.h>
+#endif
+#ifndef PATH_MAX
 #define PATH_MAX MAXPATHLEN
 #endif
 #endif
--

History
Date	User	Action	Args
2014-08-03 08:31:05	rpetrov	set	recipients: + rpetrov, jlt63, stutzbach, jbinder, BreamoreBoy, Scott.Rostrup, Nicholas.DiPiazza
2014-08-03 08:31:05	rpetrov	set	messageid: <1407054665.25.0.379196336147.issue8548@psf.upfronthosting.co.za>
2014-08-03 08:31:05	rpetrov	link	issue8548 messages
2014-08-03 08:31:05	rpetrov	create