Message307420
Given that, I'd say the way to cleanest way to fix this would be to remove these lines from "compute_code_flags" in compile.c:
if (!PyDict_GET_SIZE(c->u->u_freevars) &&
!PyDict_GET_SIZE(c->u->u_cellvars)) {
flags |= CO_NOFREE;
}
and replace them with a check like the following in PyCode_New just after we ensure the Unicode string for the filename is ready:
if (!PyTuple_GET_SIZE(freevars) &&
!PyTuple_GET_SIZE(cellvars)) {
flags |= CO_NOFREE;
}
That way CO_NOFREE will be set only when appropriate regardless of how the code object is created, rather than relying on the caller to set it correctly. |
|
| Date |
User |
Action |
Args |
| 2017-12-02 04:16:57 | ncoghlan | set | recipients:
+ ncoghlan, bup |
| 2017-12-02 04:16:57 | ncoghlan | set | messageid: <1512188217.18.0.213398074469.issue32176@psf.upfronthosting.co.za> |
| 2017-12-02 04:16:57 | ncoghlan | link | issue32176 messages |
| 2017-12-02 04:16:56 | ncoghlan | create | |
|