Message 325954 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	njs
Recipients	christian.heimes, ned.deily, njs, steve.dower
Date	2018-09-21.05:36:30
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1537508190.29.0.956365154283.issue34759@psf.upfronthosting.co.za>
In-reply-to

Content
Oh, here it is: https://github.com/python/cpython/commit/1229664f30dd5fd4da32174a19258f8312464d45#diff-e1cc5bf74055e388cda128367a814c8fR2587 - if (err < 0) { + if (err.ssl < 0) { Before in this function, 'err' was the return code from SSL_shutdown, which is -1 if an error occurred (and you're supposed to look at the SSL error code) or 0/1 on success. Now 'err.ssl' is the actual SSL error code, which as it turns out is never negative.

Oh, here it is:

https://github.com/python/cpython/commit/1229664f30dd5fd4da32174a19258f8312464d45#diff-e1cc5bf74055e388cda128367a814c8fR2587


-    if (err < 0) {
+    if (err.ssl < 0) {

Before in this function, 'err' was the return code from SSL_shutdown, which is -1 if an error occurred (and you're supposed to look at the SSL error code) or 0/1 on success. Now 'err.ssl' is the actual SSL error code, which as it turns out is never negative.

History
Date	User	Action	Args
2018-09-21 05:36:30	njs	set	recipients: + njs, christian.heimes, ned.deily, steve.dower
2018-09-21 05:36:30	njs	set	messageid: <1537508190.29.0.956365154283.issue34759@psf.upfronthosting.co.za>
2018-09-21 05:36:30	njs	link	issue34759 messages
2018-09-21 05:36:30	njs	create