Message 326351 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	ammar2
Recipients	ammar2, benjamin.peterson, emilyemorehouse, eric.smith, gvanrossum, pablogsal, xtreak
Date	2018-09-25.12:50:04
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1537879804.58.0.545547206417.issue34683@psf.upfronthosting.co.za>
In-reply-to

Content
There's some context on the github PR but essentially it boiled down to: - It would make it inconsistent with line offsets which are 1-indexed. - Breaking change to a public C API (PyErr_SyntaxLocationObject) - IDLE and other tools that catch syntax errors rely on it being 1-indexed and this would be a breaking change for them. As a quick example of that I found this vim plugin: https://github.com/vim-syntastic/syntastic/commit/6c91e8d802a77005d793d9cdd055c3da29f74a1b

There's some context on the github PR but essentially it boiled down to:

- It would make it inconsistent with line offsets which are 1-indexed.
- Breaking change to a public C API (PyErr_SyntaxLocationObject)
- IDLE and other tools that catch syntax errors rely on it being 1-indexed and this would be a breaking change for them. As a quick example of that I found this vim plugin: https://github.com/vim-syntastic/syntastic/commit/6c91e8d802a77005d793d9cdd055c3da29f74a1b

History
Date	User	Action	Args
2018-09-25 12:50:04	ammar2	set	recipients: + ammar2, gvanrossum, eric.smith, benjamin.peterson, emilyemorehouse, pablogsal, xtreak
2018-09-25 12:50:04	ammar2	set	messageid: <1537879804.58.0.545547206417.issue34683@psf.upfronthosting.co.za>
2018-09-25 12:50:04	ammar2	link	issue34683 messages
2018-09-25 12:50:04	ammar2	create