Message351945
Paul, the usual procedure is for you to mark the PR as approved and leave the commit step for the core developer who created the patch.
Also, Tim filed this issue and had put thought into it. The commit shouldn't have occurred until he had a chance to make review comments.
Tim, did the proposed (and prematurely committed) PR fully address your concerns? |
|
| Date |
User |
Action |
Args |
| 2019-09-11 15:31:51 | rhettinger | set | recipients:
+ rhettinger, tim.peters, docs@python, p-ganssle |
| 2019-09-11 15:31:51 | rhettinger | set | messageid: <1568215911.11.0.210946273226.issue38096@roundup.psfhosted.org> |
| 2019-09-11 15:31:51 | rhettinger | link | issue38096 messages |
| 2019-09-11 15:31:50 | rhettinger | create | |
|