➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eryksun
Recipients akdor1154, eryksun, paul.moore, steve.dower, tim.golden, zach.ware
Date 2020-06-03.05:33:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1591162428.06.0.0110719011566.issue40851@roundup.psfhosted.org>
In-reply-to
Content 
I think you have the right idea for improving the behavior here. It should skip setting wShowWindow if startupinfo already has the flag STARTF_USESHOWWINDOW. For example:

    if shell:
        comspec = os.environ.get("COMSPEC", "cmd.exe")
        args = '{} /c "{}"'.format (comspec, args)
        if not startupinfo.dwFlags & _winapi.STARTF_USESHOWWINDOW:
            startupinfo.dwFlags |= _winapi.STARTF_USESHOWWINDOW
            startupinfo.wShowWindow = _winapi.SW_HIDE
History
Date User Action Args
2020-06-03 05:33:48eryksunsetrecipients: + eryksun, paul.moore, tim.golden, zach.ware, steve.dower, akdor1154
2020-06-03 05:33:48eryksunsetmessageid: <1591162428.06.0.0110719011566.issue40851@roundup.psfhosted.org>
2020-06-03 05:33:48eryksunlinkissue40851 messages
2020-06-03 05:33:47eryksuncreate