➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author christian.heimes
Recipients brett.cannon, christian.heimes, gvanrossum
Date 2007-10-16.18:33:21
SpamBayes Score 0.008274022
Marked as misclassified No
Message-id <471503ED.7010305@cheimes.de>
In-reply-to <1192557323.74.0.226441796675.issue1267@psf.upfronthosting.co.za>
Content 
Christian Heimes wrote:
>  * removed unused import of open in initstdio()
>  * fixed infinite loop in PyTokenizer_FindEncoding() by checking
> tok-done == E_OK

I found another bug in Python/import.c:call_find_method. The function
mustn't set an encoding of ftp->mode contains 'b' for binary.

		if (strchr(fdp->mode, 'b') == NULL) {
			/* Python text file, get encoding from tokenizer */
			encoding = PyTokenizer_FindEncoding(fp);
			encoding = (encoding != NULL) ? encoding :
				   PyUnicode_GetDefaultEncoding();
		}

Christian
History
Date User Action Args
2007-10-16 18:33:21christian.heimessetspambayes_score: 0.00827402 -> 0.008274022
recipients: + christian.heimes, gvanrossum, brett.cannon
2007-10-16 18:33:21christian.heimeslinkissue1267 messages
2007-10-16 18:33:21christian.heimescreate