Message 62747 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	werneck
Recipients	christian.heimes, stranger4good, werneck, zanella
Date	2008-02-23.15:23:14
SpamBayes Score	0.077851005
Marked as misclassified	No
Message-id	<1203780194.93.0.402947360784.issue2118@psf.upfronthosting.co.za>
In-reply-to

Content
It seems the right thing to do would be to have it raise a base exception, but SMTPConnectError docstring states "Error during connection establishment.", so I chosen to use it with the errno and message from socket.error, even if it's supposed to happen only after connection is already stablished, since it's a subclass of SMTPResponseException. As a bonus I removed a explicit raise socket.error from line 290, when an user pass a non-integer port.

It seems the right thing to do would be to have it raise a base
exception, but SMTPConnectError docstring states "Error during
connection establishment.", so I chosen to use it with the errno and
message from socket.error, even if it's supposed to happen only after
connection is already stablished, since it's a subclass of
SMTPResponseException.

As a bonus I removed a explicit raise socket.error from line 290, when
an user pass a non-integer port.

History
Date	User	Action	Args
2008-02-23 15:23:15	werneck	set	spambayes_score: 0.077851 -> 0.077851005 recipients: + werneck, christian.heimes, stranger4good, zanella
2008-02-23 15:23:14	werneck	set	spambayes_score: 0.077851 -> 0.077851 messageid: <1203780194.93.0.402947360784.issue2118@psf.upfronthosting.co.za>
2008-02-23 15:23:14	werneck	link	issue2118 messages
2008-02-23 15:23:14	werneck	create