Message96988
Thanks for the patch.
Three minor things:
1) the source contains non-ASCII chars and an encoding declaration at
the beginning of the file. PEP8 says that "using \x, \u or \U escapes is
the preferred way to include non-ASCII data in string literals", so I
would use \x escapes and remove the encoding declaration;
2) the class "stream_source" should be named "StreamSource" unless there
are compatibility or consistency issues;
3) patches should be done against trunk first (your patch applies fine
on trunk too and the tests pass), they will then be ported to py3k. |
|
| Date |
User |
Action |
Args |
| 2009-12-29 08:39:21 | ezio.melotti | set | recipients:
+ ezio.melotti, ferringb |
| 2009-12-29 08:39:21 | ezio.melotti | set | messageid: <1262075961.51.0.424808488228.issue7594@psf.upfronthosting.co.za> |
| 2009-12-29 08:39:19 | ezio.melotti | link | issue7594 messages |
| 2009-12-29 08:39:18 | ezio.melotti | create | |
|