This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Alexander.Belopolsky
Recipients Alexander.Belopolsky, amaury.forgeotdarc, blais, loewis, vstinner
Date 2010-02-18.21:22:08
SpamBayes Score 3.679485e-06
Marked as misclassified No
Message-id <1266528130.41.0.363510557367.issue1726687@psf.upfronthosting.co.za>
In-reply-to
Content
Victor,

With issue2736, you included a variant of this patch where you use -1 as a sentinel value for tm_wday.  I think this is a better choice. (The answer to the ultimate question of life is not universally known.:-)

On a more serious note, is checking for the -1 return value necessary?  I would think a check for changed tm_wday would be enough.

Finally, a coding style nitpick: don't use superfluous parenthesis in logical expressions.
History
Date User Action Args
2010-02-18 21:22:10Alexander.Belopolskysetrecipients: + Alexander.Belopolsky, loewis, amaury.forgeotdarc, blais, vstinner
2010-02-18 21:22:10Alexander.Belopolskysetmessageid: <1266528130.41.0.363510557367.issue1726687@psf.upfronthosting.co.za>
2010-02-18 21:22:08Alexander.Belopolskylinkissue1726687 messages
2010-02-18 21:22:08Alexander.Belopolskycreate