How is this design?

Hey There Ranchers!

I know this may be a bit too much to ask,
but I would like for someone to check my program
if they could,
and to tell me a few things i could improve.
This program combines my knowledge of Java
with OOP concepts at the moment(excluding some stuff liek inheritance),
and before I take the next step, I would like to see
if there was anything i could have done better
(which i know there is).
I don't want to code incoherently (spaghetti code),
and I want to be effecient and simple as possible.
Its sort of a booking program.
oh yeah, dont be nice


So please, any suggestions on my program please let me know.
Everything does compile and runs fine.

//MainStreet Shuttle Service Booking Program //Author:Sean Magee //This class is the entry of the program public class Go{ public static void main (String [] args) { Talk.getWelcome(); } } import javax.swing.*; public class Talk{ static int passnum, depart; static String buffer, buffer_2; static Mainstreet connect = new Mainstreet(); static String main=" MainStreet Shuttle Service "; public static void getWelcome() //Welcome Message { JOptionPane.showMessageDialog(null, " Welcome To MainStreet Shuttle Service ", main, JOptionPane.INFORMATION_MESSAGE); askToPurchase(); } public static void askToPurchase() //this method is also called by //user to if { int decide=JOptionPane.showConfirmDialog(null, " Would You Like To Book a Ride On A MainStreet Shuttle?", "MainStreet Shuttle Service", JOptionPane.YES_NO_OPTION); if (decide==JOptionPane.YES_OPTION) getStarted(); else if (decide == JOptionPane.NO_OPTION) { getExit(); } } public static void getStarted()//called by getStarted() { do{ buffer= JOptionPane.showInputDialog(null, "Excellent! We Have One MainStreet Shuttle departing 4 Times Per Day.\n"+ "This Shuttle Runs From 10:00 AM to 12:00 PM,\n"+ "and There is a 40 Minute Interval Between Each Derparture Going Westward\n"+ "Please type the Number that is directly on the left of your\n"+ " Desired Time of Departure\n\n"+ "1. 10:00\n"+ "2. 10:40\n"+ "3. 11:20\n"+ "4. 12:00\n", main,JOptionPane.INFORMATION_MESSAGE); depart = Integer.parseInt(buffer); if (depart>4||depart<1) JOptionPane.showMessageDialog(null, "Not A Valid Entry. Please Try Again", main,JOptionPane.ERROR_MESSAGE); }while(depart >4||depart<1); switch (depart){ case 1: buffer="10:00";break; //This buffer String is case 2: buffer="10:40";break; //passed along most of case 3: buffer="11:20";break; //the program indicating case 4: buffer="12:00";break; //shuttle departure } do{ buffer_2 = JOptionPane.showInputDialog(null, " There Are FOUR People Allowed on the "+buffer+" Shuttle Each Day\n"+ " How Many People Would You Like To Book for the " + buffer+" Shuttle Today? ", main, JOptionPane.INFORMATION_MESSAGE); passnum = Integer.parseInt(buffer_2); if(passnum>4) { JOptionPane.showMessageDialog(null, " No More Than Four People Per Shuttle Please. ",main,JOptionPane.ERROR_MESSAGE); } }while(passnum>4); connect.toBooker(passnum,depart, buffer); } public static void getExit() {int checkbook= JOptionPane.showConfirmDialog(null, "Would You Like To See All Bookings You Have Made With MainStreet Shuttle Service?",main, JOptionPane.YES_NO_OPTION); if(checkbook==JOptionPane.YES_OPTION) {connect.onCheckOut();//this Calls Overloaded instance method if(connect.nullcounter==4) { JOptionPane.showMessageDialog(null, "Sorry, Our Records Indicate That You Haven't Made Any\n"+ "Reservations With MainStreet Shuttle Service", main, JOptionPane.ERROR_MESSAGE); } } JOptionPane.showMessageDialog(null, " Thank You For Visiting Main Street Shuttle Service, Bye! ", main,JOptionPane.INFORMATION_MESSAGE); System.exit(0); } } import javax.swing.*; public class Mainstreet{ Bus [] shuttle = new Bus [4]; public static int nullcounter =0; public void toBooker(int passnum, int depart, String time) { depart=--depart; // Preventing an OutofBounds Exception if(shuttle[depart]==null) //Preventing a nullpointer exception { shuttle[depart]=new Bus(); shuttle[depart].initArray(); } for(int x = 0; x<passnum; x++) { boolean full = shuttle[depart].checkShuttle(); //callin Instance if(full==false) { JOptionPane.showMessageDialog(null, "Sorry, This Shuttle is Now Booked!\n"+ " Please Try At Another Time", Talk.main, JOptionPane.ERROR_MESSAGE); Talk.askToPurchase(); } int seatnum=x+1; //this makes sure seatnumbers are correct on output String first = JOptionPane.showInputDialog(null, " What Is The First Name Of the Individual You Would Like To Book?", Talk.main, JOptionPane.INFORMATION_MESSAGE); String last = JOptionPane.showInputDialog(null, " What is the Last Name of the Individual You Would Like To Book?", Talk.main,JOptionPane.INFORMATION_MESSAGE); shuttle[depart].addCust(first, last); JOptionPane.showMessageDialog(null, last+", "+first+" Is Booked for Seat "+Bus.seatcounter+" On the Shuttle Departing at "+time, Talk.main, JOptionPane.WARNING_MESSAGE); } shuttle[depart].printOrder(time); Talk.askToPurchase(); } public void onCheckOut() { for (int z=0; z<shuttle.length; z++) { Bus.shuttlecounter=z+1; if(shuttle[z]==null) { nullcounter++; continue; } shuttle[z].printOrder(); //Overloaded instance method from Bus Object } } } import javax.swing.*; public class Bus { Customer [] buyer; String [] order; static int seatcounter =0; static int shuttlecounter =0; public void initArray() //creating arrays { buyer= new Customer[4]; order= new String[4]; } public boolean checkShuttle() { for (int y = 0; y<buyer.length; y++) { if (buyer[y]==null) return true; } return false; } public boolean addCust(String first, String last) { seatcounter=1; for (int x = 0; x<buyer.length; x++) { if (buyer[x]==null) { buyer[x] = new Customer(first, last); order[x] = buyer[x].createName(); return true; } seatcounter++; } return false; } public void printOrder() //overloaded method { //for onCheckOut in static Mainstreet object //created in Talk.class String depart =""; switch (shuttlecounter) { case 1: depart = "10:00";break; case 2: depart = "10:40";break; case 3: depart = "11:20";break; case 4: depart = "12:00";break; } this.printOrder(depart); } public void printOrder(String time) { String fullorder="The Complete Listing for the "+ time+" Shuttle is As Follows:\n"; for (int y =0; y< order.length; y++) { int seatnum = y+1; if(order[y]==null) order[y] = " Is Not Yet Booked\n"; fullorder+="Seat "+seatnum+": "+order[y]; } JOptionPane.showMessageDialog(null, ""+ fullorder,Talk.main,JOptionPane.INFORMATION_MESSAGE); } } public class Customer{ String firstname; String lastname; public Customer(String first, String last) { firstname = first; lastname = last; } public String createName()//used for printOrder method in Bus objects { String fullname = " Customer " + firstname+" "+lastname+" is booked \n"; return fullname; } }



Thanks in Advance!!



[ March 09, 2005: Message edited by: Sean Magee ]

I'll try to help a little bit.

1). Read Sun'sJava Coding Conventions. Your indentation in the post is off, follow naming standards.

2).
public boolean checkShuttle() //checks if shuttle is full { //this method may show to be redundant for (int y = 0; y<buyer.length; y++) { if (buyer[y]==null) return true; } return false; }

Your code here will only check the first seat. So if three people are booked, there is still a seat left, but this method will return false. Have your learned Collection classes here. You could use and ArrayList, and just check the length, if it is 4 then it is full.

3). I'd make all your instance variables private to ensure proper encapsulation.

4). In Bus.addCust, you are always resetting your seatcounter to 1 each time, What is your intention with the seatCounter (proper naming standard here)? It is only used in this method, so I would declare the variable inside the method instead of making it a static member of the Class. Probably the same with shuttleCounter.

That's just a few to get your started.

Have fun.

Mark

a few off the top of my head:

- in printOrder, use a StringBuffer or StringBuilder (5.0) to aggregate the fullorder text.
- isolate user interface from your model classes. For example, Bus shouldn't use JOptionPanes. Push as much "business" logic into Bus and other model classes as possible.
- don't use hardcoded literals ("magic numbers"), such as 4.

-j-

Don't use "static" except for its intended purpose of sharing something among all instances of a class. You've used "static" here in a classic "newbie" way, basically making everything in the Talk class static so they're easy to get to from "main()". Instead of doing this, make everything non-static, and then replace main's body with

new Talk().getWelcome();

i.e., create a Talk object to work with.

I'd like to comment, but your code is nearly unreadable in my browser because of the heavy indentation. If you could fix that...

You can edit your post by using the "pen and paper" icon at its top.

Would like to mention on how much i appreciate all of your comments.

They are extremely helpful. I changed the indentions, maybe that will help
[ March 09, 2005: Message edited by: Sean Magee ]