Need help with this array

Hello I'm working on an array on Java and I need it's really confusing me.
I have to input last names using the dialog box and store them into an array. Then take that array, loop through it to get the last character of the last name and the next to last and capitalize those characters.
Example "Smith" should return H. S. Smith, then store the new formatted names into an array and return that array.
I've created two classes
package javaconcepts; import java.util.Locale; // This class accepts an array of last names, formats the complete name and creates an array // of the formatted names, which is returned back to the calling program. public class EmployeeNames { static String[] convertNames (String[] lastNames) { String[] formattedNames = new String[lastNames.length]; for (int i=0; i<lastNames.length; i++ ) { lastNames[i]= lastNames[i].substring(lastNames.length-1); formattedNames[i]=lastNames[i]; } return formattedNames; } }
package javaconcepts; import javax.swing.JOptionPane; public class EmployeeNamesTester { public static void main(String[] args) { int count=-1; String lastName; String[] lastNamesArray = new String[10]; String[] formattedNamesArray = new String[lastNamesArray.length]; for (int i=0; i<count; i++) { lastName = JOptionPane.showInputDialog ("Enter Employee Last Name or Done to quit"); if (lastName.equals("Done") || lastName.equals("done")) break; lastNamesArray[i]= lastName; }// Write code here to prompt for the names and put them into an array // Convert the names by executing the method from EmployeeNames class formattedNamesArray = EmployeeNames.convertNames(lastNamesArray); // Loop through the array per the instructions } }

This isn't completed yet, but so far it doesn't work. So please, I don't want the answer right away to this problem but an understandable way to do this so I can get it.
=-)

Didn't look at the whole thing but your first call to substring() passes in the length of the array not the length of the name.

Welcome to the Ranch.

Reem Akira wrote:I have to input last names using the dialog box and store them into an array. Then take that array, loop through it to get the last character of the last name and the next to last and capitalize those characters.
Example "Smith" should return H. S. Smith, then store the new formatted names into an array and return that array.

In your example, shouldn't "Smith" return "T. H. Smith" because capitalize last character (H) and the next to last (T) of the last name?

ArrayList<String> = formattedName = new ArrayList<String>(); for (String lastName : nameAry) { // you may want to get each letter separately to cater for the period String lastTwoLetters = lastName.substring(lastName.length()-1).toUpperCase(); formattedName.add(lastTwoLetters + " " + lastName); } return formattedNames.toArray(new String[]); // convert list to array

Hi Reem, welcome to the ranch.

You didn't quite get the code tags right in your post so I have added them properly for you. You need to highlight the code before clicking the code tags button. If you are still not sure you can read the tutorial on how to UseCodeTags.

Tony Docherty wrote:Hi Reem, welcome to the ranch.

You didn't quite get the code tags right in your post so I have added them properly for you. You need to highlight the code before clicking the code tags button. If you are still not sure you can read the tutorial on how to UseCodeTags.

Thank you.

K. Tsang wrote:Welcome to the Ranch.

Reem Akira wrote:I have to input last names using the dialog box and store them into an array. Then take that array, loop through it to get the last character of the last name and the next to last and capitalize those characters.
Example "Smith" should return H. S. Smith, then store the new formatted names into an array and return that array.

In your example, shouldn't "Smith" return "T. H. Smith" because capitalize last character (H) and the next to last (T) of the last name?

ArrayList<String> = formattedName = new ArrayList<String>(); for (String lastName : nameAry) { // you may want to get each letter separately to cater for the period String lastTwoLetters = lastName.substring(lastName.length()-1).toUpperCase(); formattedName.add(lastTwoLetters + " " + lastName); } return formattedNames.toArray(new String[]); // convert list to array

Yes, indeed it is "T. H. Smith" That was a typo. Other thing is that I decided to use an initializer list instead of having an user inputting the names, to make it easier. Though my code still doesn't work. The output is ....not what I expected

Ok so write out exactly what you would do if you were doing it yourself before writing any code. ie:

Read the last letter in the name.
Convert it to upper case
Write it down
Write down a full stop
Read the second from last letter in the name.
Convert it to upper case
Leave a space and write it down
Write down a full stop

I'll leave you to finish this off.