onionArchitecture() now keeps ignored dependencies when overriding description#623
Conversation
|
Thanks for fixing the bug (which I had introduced with #320... 🙈)! The failing Checks however prevent your commit from being merged, as it has not been signed-off according to the DCO, cf. CONTRIBUTING.md. Could you please amend your commit and force push your branch as described? |
…iption Signed-off-by: Thomas Much <github@snailshell.de>
|
Awesome, that's my favorite issues that come with a fix, thanks a lot 😄 🙏 Looks very good to me! I hope it's okay, but I slimmed down the test a tiny bit, because I felt we don't need to combine 3 separate ignore's to reproduce the problem, a single ignore is already sufficient to cause the problem and then it's a little bit less to read the test (except if I missed something, but it failed without your change and passed with your change 🤷♂️) |
|
Sure, that's absolutely ok – looks fine. I just copied the test case for ignored dependencies and forgot to minimize the test setup... 😉 |
3 participants
When adding a because() or as() to an onionArchitecture() rule, all specified ignored dependencies were lost – which caused the architecture check to fail.
This happened because the overridden OnionArchitecture.as() method did not copy the ignoredDependencies list.
Fixes #622