fix: guessExecutionStatusRelativeTo exception#15305
Merged
Merged
Conversation
liuxingbaoyu
added
PR: Bug Fix 🐛
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53712/ |
nicolo-ribaudo
approved these changes
Dec 23, 2022
Member
|
I can work on adding tests today. |
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues.
_guessExecutionStatusRelativeTomay cause an infinite loop.Changes tested locally to work at #15299 (comment), I tried to extract the minimal failure code but failed.
For reviewers,
node_modules\.bin\babel.cmd node_modules\react-hook-form\dist\index.cjs.jsYou can quickly reproduce the error this way. (
yarn add @babel/cli)