kramdown: symbolize keys in-place#6247
Merged
Merged
Conversation
Crunch09
approved these changes
Jul 26, 2017
ghost
approved these changes
Jul 27, 2017
pathawks
approved these changes
Jul 28, 2017
| Hash | ||
| ) | ||
| hash.keys.each do |key| | ||
| hash[key.to_sym] = hash[key] |
Member
There was a problem hiding this comment.
hash[key.to_sym] = hash[key] unless key.is_a?(Symbol)?
Member
Author
There was a problem hiding this comment.
It should be a no-op since Symbol#to_sym returns self, right?
Member
Author
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Jul 28, 2017
parkr
added a commit
that referenced
this pull request
Aug 12, 2017
parkr
added a commit
that referenced
this pull request
Aug 12, 2017
Backport #6247 for v3.5.x: kramdown: symbolize keys in-place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently-released version of Jekyll uses default_proc to assign values for the kramdown config.
Kramdown::Document#initializecallsOptions.mergewhich doesHash#eachover our hash which doesn't have symbolized keys. To fix this, we need to add the symbolized keys into the hash itself.Fixes #5980.
/cc @jekyll/stability