Adding a --validate CLI option#84
Conversation
|
Can we have this? (please!) |
|
@ravi You can use my branch (referenced in this pull request) to try it :) I'm waiting for feedback or a merge on this, too |
|
Whoops, I totally missed this PR, sorry about that! Taking a quick look now. |
|
@AVGP Unfortunately I might have misunderstood your commit... I had hoped for more context for the error message, but it seems to me your change does not provide that. |
|
For my ~ 600 line JSON5 config file, the below is mostly useless as an error report, I am afraid: |
There was a problem hiding this comment.
Instead of referencing args[2] in multiple spots, let's add a variable to save it, e.g. cmd after args.
There was a problem hiding this comment.
Also, is this boolean logic right? I thought && takes precedence over ||, so you might need to wrap the -c || --validate check in parentheses.
|
Nice work otherwise @AVGP. Thank you for the pull request! =) |
|
Good point @ravi. So this won't fix that. Please feel free to open a new issue to add line and column number to syntax error messages. Hopefully it won't be too hard for someone to take a stab at. |
|
Created #86 . Thanks. |
|
Fixed in 35269da |
4 participants
Simple version of a
--validateoption for the CLI added by highjacking the-coption code.Sort-of delivers #72