Skip to content

feat: add needsCodeReference field to EmittedAsset#4805

Merged
lukastaegert merged 9 commits into
rollup:masterfrom
TrickyPi:feat/add-needsCodeReference
Jan 26, 2023
Merged

feat: add needsCodeReference field to EmittedAsset#4805
lukastaegert merged 9 commits into
rollup:masterfrom
TrickyPi:feat/add-needsCodeReference

Conversation

@TrickyPi

@TrickyPi TrickyPi commented Jan 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #4774

Description

@codecov

codecov Bot commented Jan 17, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4805 (47b3d80) into master (3b560f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4805   +/-   ##
=======================================
  Coverage   98.98%   98.99%           
=======================================
  Files         219      219           
  Lines        7814     7826   +12     
  Branches     2166     2169    +3     
=======================================
+ Hits         7735     7747   +12     
  Misses         26       26           
  Partials       53       53
Impacted Files Coverage Δ
src/utils/FileEmitter.ts 100.00% <ø> (ø)
src/Bundle.ts 100.00% <100.00%> (ø)
src/utils/outputBundle.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lukastaegert
lukastaegert reviewed Jan 20, 2023
View reviewed changes

@lukastaegert lukastaegert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is a good solution for now. I have one minor refactoring suggestion. We should explain this in the docs, but I can also write a few lines later. Definitely at https://rollupjs.org/guide/en/#thisemitfile and probably also at https://rollupjs.org/guide/en/#file-urls

Comment thread src/Bundle.ts Outdated
@TrickyPi

TrickyPi commented Jan 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

I updated relevant docs, if some information is incorrect (include English grammar or vocabulary), please feel free to correct it.

@TrickyPi TrickyPi force-pushed the feat/add-needsCodeReference branch from 6043eca to b68433b Compare January 24, 2023 15:28
@rollup rollup deleted a comment from netlify Bot Jan 26, 2023
lukastaegert
lukastaegert approved these changes Jan 26, 2023
View reviewed changes

@lukastaegert lukastaegert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The examples are very good, I slightly tweaked the wording.

@lukastaegert lukastaegert enabled auto-merge (squash) January 26, 2023 07:55
@TrickyPi

TrickyPi commented Jan 26, 2023

Copy link
Copy Markdown
Member Author

Thanks for your help too!

@lukastaegert lukastaegert merged commit 29dd9dc into rollup:master Jan 26, 2023
@rollup-bot

rollup-bot commented Jan 26, 2023

Copy link
Copy Markdown
Collaborator

This PR has been released as part of rollup@3.11.0. You can test it via npm install rollup.

@rollup-bot rollup-bot mentioned this pull request Jan 26, 2023
Closed
@TrickyPi TrickyPi deleted the feat/add-needsCodeReference branch January 26, 2023 16:03
shirotech
shirotech reviewed Jan 30, 2023
View reviewed changes
Comment thread docs/plugin-development/index.md
@sapphi-red sapphi-red mentioned this pull request Feb 19, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes
+1 more reviewer
@shirotech shirotech shirotech left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RFC: Add flag when emitting assets to not emit files that are not referenced in the output

4 participants

@TrickyPi @rollup-bot @shirotech @lukastaegert