Fix Electron release workflow: separate build and release jobs

Gerome-Elassaad · Gerome-Elassaad · commit a1ce87cf777f · 2025-11-23T04:35:04.000+11:00
- Split build and release into separate jobs to prevent race conditions
- Add platform-specific artifact upload/download between jobs
- Release job now depends on all builds completing first
- Add debug step to list dist/ contents for troubleshooting
- Each platform only uploads its own artifacts with error on missing files
diff --git a/.github/workflows/electron.yml b/.github/workflows/electron.yml
@@ -18,10 +18,10 @@ permissions:
 jobs:
   build:
     runs-on: ${{ matrix.os }}
-    
+
     strategy:
       matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest] # Use unsigned macOS builds for now
+        os: [ubuntu-latest, windows-latest, macos-latest]
         node-version: [20.15.1]
       fail-fast: false
 
@@ -57,14 +57,12 @@ jobs:
       - name: Install dependencies
         run: pnpm install
 
-      # Install Linux dependencies
       - name: Install Linux dependencies
         if: matrix.os == 'ubuntu-latest'
         run: |
           sudo apt-get update
           sudo apt-get install -y rpm
 
-      # Build
       - name: Build Electron app
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -79,21 +77,67 @@ jobs:
           fi
         shell: bash
 
-      # Create Release
+      - name: List build outputs
+        shell: bash
+        run: |
+          echo "Contents of dist directory:"
+          ls -R dist/ || echo "dist directory not found"
+
+      - name: Upload Windows artifacts
+        if: matrix.os == 'windows-latest'
+        uses: actions/upload-artifact@v4
+        with:
+          name: windows-artifacts
+          path: |
+            dist/*.exe
+            dist/*.exe.blockmap
+          if-no-files-found: error
+
+      - name: Upload macOS artifacts
+        if: matrix.os == 'macos-latest'
+        uses: actions/upload-artifact@v4
+        with:
+          name: macos-artifacts
+          path: |
+            dist/*.dmg
+            dist/*.dmg.blockmap
+          if-no-files-found: error
+
+      - name: Upload Linux artifacts
+        if: matrix.os == 'ubuntu-latest'
+        uses: actions/upload-artifact@v4
+        with:
+          name: linux-artifacts
+          path: |
+            dist/*.deb
+            dist/*.AppImage
+          if-no-files-found: error
+
+  release:
+    needs: build
+    runs-on: ubuntu-latest
+    if: startsWith(github.ref, 'refs/tags/') || github.event_name == 'workflow_dispatch'
+
+    steps:
+      - name: Download all artifacts
+        uses: actions/download-artifact@v4
+        with:
+          path: artifacts
+
+      - name: List downloaded artifacts
+        run: |
+          echo "Downloaded artifacts:"
+          ls -R artifacts/
+
       - name: Create Release
         uses: softprops/action-gh-release@v2
         with:
-          # Use the workflow_dispatch input tag if available, else use the Git ref name.
           tag_name: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.tag || github.ref_name }}
-          # Only branch pushes remain drafts. For workflow_dispatch and tag pushes the release is published.
-          draft: ${{ github.event_name != 'workflow_dispatch' && github.ref_type == 'branch' }}
-          # For tag pushes, name the release as "Release <tagname>", otherwise "Electron Release".
+          draft: false
           name: ${{ (github.event_name == 'push' && github.ref_type == 'tag') && format('Release {0}', github.ref_name) || 'Electron Release' }}
           files: |
-            dist/*.exe
-            dist/*.dmg
-            dist/*.deb
-            dist/*.AppImage
-            dist/*.zip
+            artifacts/windows-artifacts/*
+            artifacts/macos-artifacts/*
+            artifacts/linux-artifacts/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
