add support for native arrays of html elements

jlmakes · jlmakes · commit 63b9aa1281bb · 2017-07-31T02:44:46.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project tries its best to use [Semantic Versioning](http://semver.org/)
 - New `clean()` method removes specific generated styles and event listeners. [#227](https://github.com/jlmakes/scrollreveal/issues/227)
 - New `destroy()` method removes all generated styles and event listeners. [#227](https://github.com/jlmakes/scrollreveal/issues/227)
 - New `debug` instance property toggles error messages in console. [#351](https://github.com/jlmakes/scrollreveal/issues/351)
+- Instance methods now accept native arrays of HTML elements.
 
 ### Changed
 - **Breaking:** The `reveal()` method will not accept sequence intervals less than 16 milliseconds.
diff --git a/src/utils/core.js b/src/utils/core.js
@@ -80,14 +80,17 @@ export function getNode (target, container = document) {
 
 
 export function getNodes (target, container = document) {
+	if (target instanceof Array) {
+		return target
+	}
 	if (isNode(target)) {
 		return [target]
 	}
 	if (isNodeList(target)) {
 		return Array.prototype.slice.call(target)
 	}
-	let query
 	if (typeof target === 'string') {
+		let query
 		try {
 			query = container.querySelectorAll(target)
 		} catch (e) {
@@ -96,8 +99,8 @@ export function getNodes (target, container = document) {
 		if (query.length === 0) {
 			throw new Error(`The selector "${target}" matches 0 elements.`)
 		}
+		return Array.prototype.slice.call(query)
 	}
-	return Array.prototype.slice.call(query)
 }
 
 
diff --git a/test/utils/core.spec.js b/test/utils/core.spec.js
@@ -42,6 +42,12 @@ describe('Core Utilities', () => {
 
 	describe('getNodes()', () => {
 
+		it('should return the same array of nodes when passed an array of nodes', () => {
+			const actual = [].concat(document.querySelectorAll('html, body, script'))
+			const result = getNodes(actual)
+			expect(result).to.equal(actual)
+		})
+
 		it('should return an array containing the same node when passed a node', () => {
 			const element = document.documentElement
 			const actual = [element]

Original file line number	Diff line number	Diff line change
`@@ -80,14 +80,17 @@ export function getNode (target, container = document) {`
`80`	`80`
`81`	`81`
`82`	`82`	`export function getNodes (target, container = document) {`
	`83`	`+ if (target instanceof Array) {`
	`84`	`+ return target`
	`85`	`+ }`
`83`	`86`	`if (isNode(target)) {`
`84`	`87`	`return [target]`
`85`	`88`	`}`
`86`	`89`	`if (isNodeList(target)) {`
`87`	`90`	`return Array.prototype.slice.call(target)`
`88`	`91`	`}`
`89`		`- let query`
`90`	`92`	`if (typeof target === 'string') {`
	`93`	`+ let query`
`91`	`94`	`try {`
`92`	`95`	`query = container.querySelectorAll(target)`
`93`	`96`	`} catch (e) {`
`@@ -96,8 +99,8 @@ export function getNodes (target, container = document) {`
`96`	`99`	`if (query.length === 0) {`
`97`	`100`	throw new Error(`The selector "${target}" matches 0 elements.`)
`98`	`101`	`}`
	`102`	`+ return Array.prototype.slice.call(query)`
`99`	`103`	`}`
`100`		`- return Array.prototype.slice.call(query)`
`101`	`104`	`}`
`102`	`105`
`103`	`106`