feat(config): add sensitive attribute metadata to configuration params#4775
Draft
PranjalC100 wants to merge 1 commit into
Draft
feat(config): add sensitive attribute metadata to configuration params#4775PranjalC100 wants to merge 1 commit into
PranjalC100 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4775 +/- ##
==========================================
+ Coverage 83.67% 83.69% +0.01%
==========================================
Files 168 168
Lines 20784 20784
==========================================
+ Hits 17392 17396 +4
+ Misses 2742 2739 -3
+ Partials 650 649 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
sensitiveproperty for all GCSFuse configuration parameters. The configuration generator (tools/config-gen) is updated to parse and validate that thesensitiveattribute is explicitly set (trueorfalse) for every parameter defined incfg/params.yaml.The following 11 parameters have been classified as sensitive (
sensitive: true):cache-dir(Flag:--cache-dir)file-system.kernel-params-file(Flag:--kernel-params-file)file-system.temp-dir(Flag:--temp-dir)gcs-auth.key-file(Flag:--key-file)gcs-auth.token-url(Flag:--token-url)gcs-connection.custom-endpoint(Flag:--custom-endpoint)gcs-connection.experimental-local-socket-address(Flag:--experimental-local-socket-address)logging.file-path(Flag:--log-file)logging.wire-log(Flag:--wire-log)only-dir(Flag:--only-dir)workload-insight.output-file(Flag:--workload-insight-output-file)All other parameters are explicitly marked as
sensitive: false.Link to the issue in case of a bug fix.
N/A
Testing details
go generate ./...succeeds and generated files remain correct. Audited all parameters incfg/params.yamlto ensure no sensitive path, socket, or token configurations are missed.go test ./cfg/...(Passed),go test ./tools/config-gen/...(Passed)Any backward incompatible change? If so, please explain.
N/A