Commit 3b5b444
Address CI codex round 2 P3 wording drift on PR igerber#477
CI Codex R2 verdict: ✅ Looks good (0 P0/P1/P2). One actionable P3 (docs
wording drift across 4 surfaces).
Fixes:
- docs/api/spillover.rst H=1 lag>0 reduction: "plain Newey-West Bartlett
HAC on per-PSU score sequences" -> "Newey-West Bartlett HAC on per-period
within-stratum-CENTERED per-PSU score sequences (NOT raw — Binder TSL
centering is retained at H=1)". Now matches REGISTRY which was already
updated in the previous push.
- diff_diff/two_stage.py _compute_gmm_corrected_meat docstring: "Requires
survey_design.psu set" -> "Requires an effective PSU — either explicit
survey_design.psu OR cluster=<col> injected as the effective PSU per
Wave E.1's _inject_cluster_as_psu routing". Aligns the inline docstring
with the actual post-resolution gate at spillover.py.
- CHANGELOG.md: removed "full meat matrix" overclaim. The lag=0 regression
pin uses assert_array_equal on user-visible ATT + scalar SE (the meat
matrix is not exposed on SpilloverDiDResults); the test_a2 mock-spy
independently asserts the serial helper isn't invoked at lag=0.
- tests/test_spillover.py class docstring: same "full meat matrix" wording
trimmed to "ATT and scalar SE bit-identity (test_a) plus mock-spy that
the serial helper isn't invoked (test_a2)".
P3 informational items NOT addressed (out of scope for this PR per the
recurring codex assessment):
- Serial Bartlett kernel duplication between two_stage.py + conley.py
(TODO.md row added in previous push; refactor would touch the no-survey
panel-block path)
- no-effective-PSU survey + lag>0 fail-closed restriction (TODO.md row
exists; methodology derivation pending)
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent fbdfe55 commit 3b5b444
4 files changed
Lines changed: 16 additions & 8 deletions
0 commit comments