Security Fix of Flash SWF that had enabled cookie theft

thepag · thepag · commit e8ca190f7f97 · 2013-03-21T17:12:38.000Z
diff --git a/actionscript/Jplayer.as b/actionscript/Jplayer.as
@@ -8,8 +8,8 @@
  *  - http://www.gnu.org/copyleft/gpl.html
  *
  * Author: Mark J Panaghiston
- * Version: 2.2.19
- * Date: 29th January 2013
+ * Version: 2.2.20
+ * Date: 21st March 2013
  *
  * FlashVars expected: (AS3 property of: loaderInfo.parameters)
  *	id: 	(URL Encoded: String) Id of jPlayer instance
@@ -70,7 +70,7 @@ package {
 		private var isVideo:Boolean = false;
 
 		private var securityIssue:Boolean = false; // When SWF parameters contain illegal characters
-		private var directAccess:Boolean = false; // When SWF visited directly with no parameters
+		private var directAccess:Boolean = false; // When SWF visited directly with no parameters (or when security issue detected)
 
 		private var txLog:TextField;
 		private var debug:Boolean = false; // Set debug to false for release compile!
@@ -233,12 +233,12 @@ package {
 				}
 				i++;
 			}
-			if(i === 0) {
+			if(i === 0 || securityIssue) {
 				directAccess = true;
 			}
 		}
 		private function illegalChar(s:String):Boolean {
-			var illegals:String = "' \" ( ) { } * + /";
+			var illegals:String = "' \" ( ) { } * + / \\ < > = document";
 			if(Boolean(s)) { // Otherwise exception if parameter null.
 				for each (var illegal:String in illegals.split(' ')) {
 					if(s.indexOf(illegal) >= 0) {
diff --git a/actionscript/happyworm/jPlayer/JplayerStatus.as b/actionscript/happyworm/jPlayer/JplayerStatus.as
@@ -8,13 +8,13 @@
  *  - http://www.gnu.org/copyleft/gpl.html
  *
  * Author: Mark J Panaghiston
- * Date: 29th January 2013
+ * Date: 21st March 2013
  */
 
 package happyworm.jPlayer {
 	public class JplayerStatus {
 
-		public static const VERSION:String = "2.2.19"; // The version of the Flash jPlayer entity.
+		public static const VERSION:String = "2.2.20"; // The version of the Flash jPlayer entity.
 
 		public var volume:Number = 0.5; // Not affected by reset()
 		public var muted:Boolean = false; // Not affected by reset()
diff --git a/jquery.jplayer/Jplayer.swf b/jquery.jplayer/Jplayer.swf
diff --git a/jquery.jplayer/jquery.jplayer.js b/jquery.jplayer/jquery.jplayer.js
@@ -8,8 +8,8 @@
  *  - http://www.gnu.org/copyleft/gpl.html
  *
  * Author: Mark J Panaghiston
- * Version: 2.2.19
- * Date: 29th January 2013
+ * Version: 2.2.20
+ * Date: 21st March 2013
  */
 
 /* Code verified using http://www.jshint.com/ */
@@ -454,8 +454,8 @@
 	$.jPlayer.prototype = {
 		count: 0, // Static Variable: Change it via prototype.
 		version: { // Static Object
-			script: "2.2.19",
-			needFlash: "2.2.19",
+			script: "2.2.20",
+			needFlash: "2.2.20",
 			flash: "unknown"
 		},
 		options: { // Instanced in $.jPlayer() constructor

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,8 @@`
`8`	`8`	`* - http://www.gnu.org/copyleft/gpl.html`
`9`	`9`	`*`
`10`	`10`	`* Author: Mark J Panaghiston`
`11`		`- * Version: 2.2.19`
`12`		`- * Date: 29th January 2013`
	`11`	`+ * Version: 2.2.20`
	`12`	`+ * Date: 21st March 2013`
`13`	`13`	`*`
`14`	`14`	`* FlashVars expected: (AS3 property of: loaderInfo.parameters)`
`15`	`15`	`* id: (URL Encoded: String) Id of jPlayer instance`
`@@ -70,7 +70,7 @@ package {`
`70`	`70`	`private var isVideo:Boolean = false;`
`71`	`71`
`72`	`72`	`private var securityIssue:Boolean = false; // When SWF parameters contain illegal characters`
`73`		`- private var directAccess:Boolean = false; // When SWF visited directly with no parameters`
	`73`	`+ private var directAccess:Boolean = false; // When SWF visited directly with no parameters (or when security issue detected)`
`74`	`74`
`75`	`75`	`private var txLog:TextField;`
`76`	`76`	`private var debug:Boolean = false; // Set debug to false for release compile!`
`@@ -233,12 +233,12 @@ package {`
`233`	`233`	`}`
`234`	`234`	`i++;`
`235`	`235`	`}`
`236`		`- if(i === 0) {`
	`236`	`+ if(i === 0 \|\| securityIssue) {`
`237`	`237`	`directAccess = true;`
`238`	`238`	`}`
`239`	`239`	`}`
`240`	`240`	`private function illegalChar(s:String):Boolean {`
`241`		`- var illegals:String = "' \" ( ) { } * + /";`
	`241`	`+ var illegals:String = "' \" ( ) { } * + / \\ < > = document";`
`242`	`242`	`if(Boolean(s)) { // Otherwise exception if parameter null.`
`243`	`243`	`for each (var illegal:String in illegals.split(' ')) {`
`244`	`244`	`if(s.indexOf(illegal) >= 0) {`