Fix safari/firefox detection of Meta key up

knolleary · knolleary · commit de225205bdfa · 2016-11-06T00:24:01.000Z
diff --git a/editor/js/ui/view.js b/editor/js/ui/view.js
@@ -1177,7 +1177,8 @@ RED.view = (function() {
     }
 
     function disableQuickJoinEventHandler(evt) {
-        if (evt.keyCode === 17 || evt.keyCode === 91) {
+        // Check for ctrl (all browsers), "Meta" (Chrome/FF), keyCode 91 (Safari)
+        if (evt.keyCode === 17 || evt.key === "Meta" || evt.keyCode === 91) {
             resetMouseVars();
             hideDragLines();
             redraw();

Original file line number	Diff line number	Diff line change
`@@ -1177,7 +1177,8 @@ RED.view = (function() {`
`1177`	`1177`	`}`
`1178`	`1178`
`1179`	`1179`	`function disableQuickJoinEventHandler(evt) {`
`1180`		`- if (evt.keyCode === 17 \|\| evt.keyCode === 91) {`
	`1180`	`+ // Check for ctrl (all browsers), "Meta" (Chrome/FF), keyCode 91 (Safari)`
	`1181`	`+ if (evt.keyCode === 17 \|\| evt.key === "Meta" \|\| evt.keyCode === 91) {`
`1181`	`1182`	`resetMouseVars();`
`1182`	`1183`	`hideDragLines();`
`1183`	`1184`	`redraw();`