Merge pull request wesbos#617 from issam-seghir/pull-request

palashmon · Kiselt · commit 1ca2c57fb71b · 2024-05-11T15:19:06.000+02:00
add my project link in the readme
diff --git a/01 - JavaScript Drum Kit/index-START.html b/01 - JavaScript Drum Kit/index-START.html
@@ -60,6 +60,25 @@
 
 <script>
 
+function playSound(e) {
+  const audio = document.querySelector(`audio[data-key="${e.keyCode}"]`)
+  const key = document.querySelector(`.key[data-key="${e.keyCode}"]`)
+  if(!audio) return; //stop the function from running all together
+  audio.currentTime = 0; //rewind to the start
+  audio.play();
+  key.classList.add('playing');
+};
+
+
+function removeTransition(e) {
+  if (e.propertyName !== 'transform') return; //skip if it's not a transform
+  this.classList.remove('playing');
+}
+
+const keys = document.querySelectorAll('.key');
+keys.forEach(key => key.addEventListener('transitionend', removeTransition));
+window.addEventListener('keydown', playSound);
+
 </script>
 
 
diff --git a/07 - Array Cardio Day 2/index-START.html b/07 - Array Cardio Day 2/index-START.html
@@ -27,16 +27,41 @@
 
     // Some and Every Checks
     // Array.prototype.some() // is at least one person 19 or older?
-    // Array.prototype.every() // is everyone 19 or older?
+    // const isAdult = people.some(function(person) {
+    //   const currentYear = (new Date()).getFullYear();
+    //   if(currentYear - person.year >= 19) {
+    //     return true;
+    //   }
+    // });
 
+    const isAdult = people.some(person => ((new Date()).getFullYear()) - person.year >= 19);
+    
+    console.log(isAdult);
+    // Array.prototype.every() // is everyone 19 or older?
+    const allAdults = people.every(person => ((new Date()).getFullYear()) - person.year >= 19);
+    
+    console.log(allAdults);
     // Array.prototype.find()
     // Find is like filter, but instead returns just the one you are looking for
     // find the comment with the ID of 823423
+    // const comment = comments.find(function(comment) {
+    //   if(comment.id === 823423) {
+    //     return true;
+    //   }
+    // });
+
+    const comment = comments.find(comment => comment.id === 823423);
+
+    console.log(comment);
 
     // Array.prototype.findIndex()
     // Find the comment with this ID
     // delete the comment with the ID of 823423
+    const index = comments.findIndex(comment => comment.id === 823423);
+    console.log(index);
 
+    comments.splice(index, 1);
+    console.table(comments);
   </script>
 </body>
 </html>
diff --git a/readme.md b/readme.md
@@ -55,6 +55,7 @@ Feel free to submit a PR adding a link to your own recaps, guides or reviews!
 * [Mo. Saif's](https://github.com/MoSaif00)note on lessons learned and a [gh-pages showcase](https://mosaif00.github.io/30-Days-JavaScript-Challenge/) for the projects.
 * [Stiaannel's](https://stiaannel.co.za/my-projects/javascript30) implementation of the Javascript30 challenge, with small design changes and a couple of extra features.
 * [Kelly CHI's](https://kellychi22.github.io/JavaScript30/) complete JavaScript30 challenges! Click the links to check demos and notes of each challenge. 🇹🇼 🌟
+* [Issam Seghir](https://issam-seghir.github.io/JavaScript30/)  added custom solutions and styles 🍧, improved performance, including fixed bugs/issus 💢. , added articles for each exercise 📝.
 
 ## Alternative Implementations
 Here are some links of people who have done the tutorials, but in a different language or framework:
