Skip to content

Correctly cache tagged template objects in modules#18300

Merged
DanielRosenwasser merged 29 commits into
masterfrom
correctlyCacheTaggedTemplates
Oct 3, 2017
Merged

Correctly cache tagged template objects in modules#18300
DanielRosenwasser merged 29 commits into
masterfrom
correctlyCacheTaggedTemplates

Conversation

@DanielRosenwasser

@DanielRosenwasser DanielRosenwasser commented Sep 7, 2017

Copy link
Copy Markdown
Member

This PR is a work in progress at the moment

Remaining things to work on:

  • Bikeshed on helper name.
  • Bikeshed on helper semantics
  • Bikeshed on template object initialization location
  • Add helper for tslib
  • Add test for tslib
  • Investigate adding behavioral tests
  • Fix weird case with un-parenthesized new expressions

Fixes #17956

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants