I think I might have stumbled over a very strange edge case. When installing a very specific other VS Code extension, login to github.com doesn't work. As soon as I disabled the docs-article-templates extension, sign in starts to work as expected.
To me, the stacktrace looks like a module resolution issue of one of the extension's dependencies but I haven't dug deeper into this.
- Extension version: 0.1.3
- VSCode Version: 1.28.0-insider
- OS: macOS 10.13.6
Steps to Reproduce:
- Clone a github.com repo using the SSH option
- Install the docs-article-templates extension
- Try to sign in to GitHub with the extension:
Error signing in to github.com: TypeError: Cannot read property 'protocol' of undefined
TypeError: Cannot read property 'protocol' of undefined
at Function.ClientRequestParser._getUrlFromRequestOptions (/Users/lukas/.vscode-insiders/extensions/docsmsft.docs-article-templates-0.1.2/node_modules/applicationinsights/AutoCollection/ClientRequestParser.js:111:62)
at new ClientRequestParser (/Users/lukas/.vscode-insiders/extensions/docsmsft.docs-article-templates-0.1.2/node_modules/applicationinsights/AutoCollection/ClientRequestParser.js:23:45)
at Function.AutoCollectClientRequests.trackRequest (/Users/lukas/.vscode-insiders/extensions/docsmsft.docs-article-templates-0.1.2/node_modules/applicationinsights/AutoCollection/ClientRequests.js:68:29)
at Object.http.request (/Users/lukas/.vscode-insiders/extensions/docsmsft.docs-article-templates-0.1.2/node_modules/applicationinsights/AutoCollection/ClientRequests.js:37:43)
at Object.request (https.js:239:15)
at Object.<anonymous> (/Users/lukas/.vscode-insiders/extensions/shan.code-settings-sync-3.1.2/node_modules/agent-base/patch-core.js:23:20)
at Object.n.request (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:8:7222)
at Object.n.get (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:8:7266)
at w.<anonymous> (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:1:87622)
at new w (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:1:88782)
at Promise (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:1:94569)
at new Promise (<anonymous>)
at g.start (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:1:94532)
at t.GitHubServer.<anonymous> (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:1:96950)
at Generator.next (<anonymous>)
at /Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:1:94188
at new Promise (<anonymous>)
at i (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:1:93965)
at t.GitHubServer.login (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:1:96873)
at t.CredentialStore.<anonymous> (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:8:22323)
at Generator.next (<anonymous>)
at o (/Users/lukas/.vscode-insiders/extensions/github.vscode-pull-request-github-0.1.3/media/extension.js:8:20583)
at <anonymous>
I think I might have stumbled over a very strange edge case. When installing a very specific other VS Code extension, login to github.com doesn't work. As soon as I disabled the docs-article-templates extension, sign in starts to work as expected.
To me, the stacktrace looks like a module resolution issue of one of the extension's dependencies but I haven't dug deeper into this.
Steps to Reproduce: