Skip to content

Switch to markdown#190

Merged
fdiblen merged 22 commits into
mainfrom
162-use-markdown
Apr 20, 2021
Merged

Switch to markdown#190
fdiblen merged 22 commits into
mainfrom
162-use-markdown

Conversation

@fdiblen

@fdiblen fdiblen commented Apr 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: #169 #162 #178

This was referenced Apr 20, 2021
Closed
Closed
@fdiblen fdiblen marked this pull request as ready for review April 20, 2021 15:37
jspaaks
jspaaks reviewed Apr 20, 2021
View reviewed changes
Comment thread {{cookiecutter.project_name}}/README.md Outdated
jspaaks
jspaaks reviewed Apr 20, 2021
View reviewed changes
Comment thread {{cookiecutter.project_name}}/README.md Outdated
jspaaks
jspaaks reviewed Apr 20, 2021
View reviewed changes
Comment thread {{cookiecutter.project_name}}/README.md Outdated
jspaaks
jspaaks reviewed Apr 20, 2021
View reviewed changes
Comment thread {{cookiecutter.project_name}}/CHANGELOG.md Outdated
jspaaks
jspaaks reviewed Apr 20, 2021
View reviewed changes
Comment thread {{cookiecutter.project_name}}/CODE_OF_CONDUCT.md Outdated
fdiblen and others added 2 commits April 20, 2021 17:42
@fdiblen @jspaaks
Update {{cookiecutter.project_name}}/CHANGELOG.md
cc2bbf1 
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
@fdiblen @jspaaks
Update {{cookiecutter.project_name}}/CODE_OF_CONDUCT.md
d0e08e1 
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
jspaaks
jspaaks reviewed Apr 20, 2021
View reviewed changes
Comment thread {{cookiecutter.project_name}}/README.md Outdated
@fdiblen @jspaaks
Update {{cookiecutter.project_name}}/README.md
f3f0d9f 
Co-authored-by: Jurriaan H. Spaaks <j.spaaks@esciencecenter.nl>
jspaaks
jspaaks reviewed Apr 20, 2021
View reviewed changes
Comment thread {{cookiecutter.project_name}}/README.md Outdated
jspaaks
jspaaks suggested changes Apr 20, 2021
View reviewed changes

@jspaaks jspaaks left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of changes but overall great job! 🦅

@jspaaks

jspaaks commented Apr 20, 2021

Copy link
Copy Markdown

.mlc-config.json can be used to add a couple of exceptions, like 👍

ERROR: 3 dead links found!
[✖] https://doi.org/<replace-with-created-DOI> → Status: 404
[✖] https://bestpractices.coreinfrastructure.org/projects/<replace-with-created-project-identifier> → Status: 404
[✖] https://bestpractices.coreinfrastructure.org/projects/<replace-with-created-project-identifier>/badge → Status: 404

@fdiblen fdiblen requested a review from jspaaks April 20, 2021 16:10
jspaaks
jspaaks approved these changes Apr 20, 2021
View reviewed changes

@jspaaks jspaaks left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 yay

@fdiblen fdiblen merged commit 2201bd5 into main Apr 20, 2021
@fdiblen fdiblen deleted the 162-use-markdown branch April 20, 2021 16:28
This was referenced Apr 20, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jspaaks jspaaks jspaaks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fdiblen @jspaaks