fix: rethrow NativeScriptException in LoadESModule for better error handling

edusperoni · edusperoni · commit f7133def5105 · 2026-05-16T22:49:32.000-03:00
diff --git a/NativeScript/runtime/ModuleInternal.mm b/NativeScript/runtime/ModuleInternal.mm
@@ -168,11 +168,12 @@ bool IsESModule(const std::string& path) {
     Local<Value> moduleNamespace;
     try {
       moduleNamespace = ModuleInternal::LoadESModule(isolate, path);
-    } catch (const NativeScriptException& ex) {
+    } catch (NativeScriptException& ex) {
       if (RuntimeConfig.IsDebug) {
         Log(@"Error loading ES module: %s", path.c_str());
         Log(@"Exception: %s", ex.getMessage().c_str());
       }
+      ex.ReThrowToV8(isolate);
       return false;
     }
     return true;
@@ -202,6 +203,9 @@ bool IsESModule(const std::string& path) {
         tns::LogError(isolate, tc);
       }
     }
+    if (tc.HasCaught()) {
+      tc.ReThrow();
+    }
     return false;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -168,11 +168,12 @@ bool IsESModule(const std::string& path) {`
`168`	`168`	`Local<Value> moduleNamespace;`
`169`	`169`	`try {`
`170`	`170`	`moduleNamespace = ModuleInternal::LoadESModule(isolate, path);`
`171`		`- } catch (const NativeScriptException& ex) {`
	`171`	`+ } catch (NativeScriptException& ex) {`
`172`	`172`	`if (RuntimeConfig.IsDebug) {`
`173`	`173`	`Log(@"Error loading ES module: %s", path.c_str());`
`174`	`174`	`Log(@"Exception: %s", ex.getMessage().c_str());`
`175`	`175`	`}`
	`176`	`+ ex.ReThrowToV8(isolate);`
`176`	`177`	`return false;`
`177`	`178`	`}`
`178`	`179`	`return true;`
`@@ -202,6 +203,9 @@ bool IsESModule(const std::string& path) {`
`202`	`203`	`tns::LogError(isolate, tc);`
`203`	`204`	`}`
`204`	`205`	`}`
	`206`	`+ if (tc.HasCaught()) {`
	`207`	`+ tc.ReThrow();`
	`208`	`+ }`
`205`	`209`	`return false;`
`206`	`210`	`}`
`207`	`211`