Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ValiMail/authentication-headers
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: OSSTech-JP/python-email-authheaders
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: osstech
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 14, 2025

  1. Configuration menu
    Copy the full SHA
    2244296 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2026

  1. fix: authenticate_message: Do not set None to spf_result.smtp_mailfrom

    Closes issue #33.
    
    ```
    self = <test_authentication.TestAuthenticateMessage testMethod=test_authenticate_dmarc_prev_spf>
    
        def test_authenticate_dmarc_prev_spf(self):
            prev = "Authentication-Results: example.com; spf=pass smtp.mailfrom=gmail.com"
    >       res = authenticate_message(self.message2, "example.com", prev=prev, spf=False, dkim=True, dmarc=True, dnsfunc=self.dnsfunc)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    
    authheaders/test/test_authentication.py:155:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
    authheaders/__init__.py:434: in authenticate_message
        return str(auth_res)
               ^^^^^^^^^^^^^
    /usr/lib/python3/dist-packages/authres/core.py:476: in __str__
        return ''.join((self.HEADER_FIELD_NAME, ': ', self.header_value()))
                                                      ^^^^^^^^^^^^^^^^^^^
    /usr/lib/python3/dist-packages/authres/core.py:492: in header_value
        strs.append(str(result))
                    ^^^^^^^^^^^
    /usr/lib/python3/dist-packages/authres/core.py:222: in __str__
        strs.append(str(property_))
                    ^^^^^^^^^^^^^^
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
    
    self = <authres.core.AuthenticationResultProperty object at 0x7fc4178465f0>
    
        def __str__(self):
            if self.comment:
                return '%s.%s=%s (%s)' % (self.type, self.name, self.value.quote_if_needed(), self.comment)
            else:
    >           return '%s.%s=%s' % (self.type, self.name, self.value.quote_if_needed())
                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^
    E           AttributeError: 'NoneType' object has no attribute 'quote_if_needed'
    
    /usr/lib/python3/dist-packages/authres/core.py:132: AttributeError
    ```
    fumiyas committed Mar 23, 2026
    Configuration menu
    Copy the full SHA
    2d25cbd View commit details
    Browse the repository at this point in the history
Loading