[[ TileCache ]] Fix tiles composited at wrong offset when group focus changed

livecodeian · livecodeian · commit 76b901a523f9 · 2019-08-16T11:14:55.000+01:00
This patch fixes an issue where changes to group keyboard focus which change the
effective rect of the group would not trigger an update of the layer rect,
leading to a mismatch between the previously cached tiles and the offset at
which they are rendered.

As groups don't render a focus border, the effective rect should not change when
focused.
diff --git a/engine/src/group.cpp b/engine/src/group.cpp
@@ -956,6 +956,12 @@ Boolean MCGroup::doubleup(uint2 which)
 	return False;
 }
 
+uint2 MCGroup::gettransient(void) const
+{
+	// OVERRIDE - groups do not have a transient focus border
+	return 0;
+}
+
 void MCGroup::applyrect(const MCRectangle &nrect)
 {
 	bool t_size_changed;
diff --git a/engine/src/group.h b/engine/src/group.h
@@ -90,6 +90,7 @@ class MCGroup : public MCControl, public MCMixinObjectHandle<MCGroup>
 	virtual Boolean mup(uint2 which, bool p_release);
 	virtual Boolean doubledown(uint2 which);
 	virtual Boolean doubleup(uint2 which);
+	virtual uint2 gettransient(void) const;
 	virtual void applyrect(const MCRectangle &nrect);
 
     virtual void removereferences(void);

Original file line number	Diff line number	Diff line change
`@@ -956,6 +956,12 @@ Boolean MCGroup::doubleup(uint2 which)`
`956`	`956`	`return False;`
`957`	`957`	`}`
`958`	`958`
	`959`	`+uint2 MCGroup::gettransient(void) const`
	`960`	`+{`
	`961`	`+ // OVERRIDE - groups do not have a transient focus border`
	`962`	`+ return 0;`
	`963`	`+}`
	`964`	`+`
`959`	`965`	`void MCGroup::applyrect(const MCRectangle &nrect)`
`960`	`966`	`{`
`961`	`967`	`bool t_size_changed;`