fix: client destruction infinite wait when connect failed

Alexandre jublot · Alexandre jublot · commit a9b23d69a107 · 2022-11-08T14:01:48.000+01:00
diff --git a/src/src/tcp/ClientImpl.cpp b/src/src/tcp/ClientImpl.cpp
@@ -131,6 +131,8 @@ void polymorph::network::tcp::ClientImpl::_doReceive()
 
 polymorph::network::tcp::ClientImpl::~ClientImpl()
 {
+    if (!_isConnected)
+        return;
     polymorph::network::DisconnectionDto dto;
     std::promise<void> promise;
     auto future = promise.get_future();
diff --git a/src/src/udp/ClientImpl.cpp b/src/src/udp/ClientImpl.cpp
@@ -47,6 +47,8 @@ polymorph::network::udp::ClientImpl::ClientImpl(std::string host, std::uint16_t
 
 polymorph::network::udp::ClientImpl::~ClientImpl()
 {
+    if (!_isConnected)
+        return;
     DisconnectionDto dto;
     std::promise<void> promise;
     auto future = promise.get_future();

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,8 @@ void polymorph::network::tcp::ClientImpl::_doReceive()`
`131`	`131`
`132`	`132`	`polymorph::network::tcp::ClientImpl::~ClientImpl()`
`133`	`133`	`{`
	`134`	`+ if (!_isConnected)`
	`135`	`+ return;`
`134`	`136`	`polymorph::network::DisconnectionDto dto;`
`135`	`137`	`std::promise<void> promise;`
`136`	`138`	`auto future = promise.get_future();`
Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,8 @@ polymorph::network::udp::ClientImpl::ClientImpl(std::string host, std::uint16_t`
`47`	`47`
`48`	`48`	`polymorph::network::udp::ClientImpl::~ClientImpl()`
`49`	`49`	`{`
	`50`	`+ if (!_isConnected)`
	`51`	`+ return;`
`50`	`52`	`DisconnectionDto dto;`
`51`	`53`	`std::promise<void> promise;`
`52`	`54`	`auto future = promise.get_future();`