Make classes having only static members static

xtqqczze · xtqqczze · commit e0e60ba88a05 · 2020-10-13T00:56:01.000+01:00
diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/TimeZoneCommands.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/TimeZoneCommands.cs
@@ -428,15 +428,8 @@ protected void ThrowWin32Error()
 
         #region Win32 interop helper
 
-        internal class NativeMethods
+        internal static class NativeMethods
         {
-            /// <summary>
-            /// Private constructor to prevent instantiation.
-            /// </summary>
-            private NativeMethods()
-            {
-            }
-
             #region Native DLL locations
 
             private const string SetDynamicTimeZoneApiDllName = "api-ms-win-core-timezone-l1-1-0.dll";
diff --git a/src/Microsoft.PowerShell.LocalAccounts/LocalAccounts/StringUtil.cs b/src/Microsoft.PowerShell.LocalAccounts/LocalAccounts/StringUtil.cs
@@ -9,15 +9,8 @@ namespace System.Management.Automation.SecurityAccountsManager
     /// <summary>
     /// Contains utility functions for formatting localizable strings.
     /// </summary>
-    internal class StringUtil
+    internal static class StringUtil
     {
-        /// <summary>
-        /// Private constructor to precent auto-generation of a default constructor with greater accessability.
-        /// </summary>
-        private StringUtil()
-        {
-        }
-
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
         internal static string Format(string str)
         {
diff --git a/src/Microsoft.PowerShell.ScheduledJob/ScheduledJobDefinition.cs b/src/Microsoft.PowerShell.ScheduledJob/ScheduledJobDefinition.cs
@@ -2300,7 +2300,7 @@ internal string FQEID
     /// <summary>
     /// Simple string formatting helper.
     /// </summary>
-    internal class StringUtil
+    internal static class StringUtil
     {
         internal static string Format(string formatSpec, object o)
         {

Original file line number	Diff line number	Diff line change
`@@ -2300,7 +2300,7 @@ internal string FQEID`
`2300`	`2300`	`/// <summary>`
`2301`	`2301`	`/// Simple string formatting helper.`
`2302`	`2302`	`/// </summary>`
`2303`		`- internal class StringUtil`
	`2303`	`+ internal static class StringUtil`
`2304`	`2304`	`{`
`2305`	`2305`	`internal static string Format(string formatSpec, object o)`
`2306`	`2306`	`{`