inserttable: update documentation

Cito · Cito · commit aa6fee8c00ad · 2026-01-25T21:31:00.000Z
diff --git a/docs/contents/pg/connection.rst b/docs/contents/pg/connection.rst
@@ -495,7 +495,8 @@ This method allows to *quickly* insert large blocks of data in a table.
 Internally, it uses the COPY command of the PostgreSQL database.
 The method takes an iterable of row values which must be tuples or lists
 of the same size, containing the values for each inserted row.
-These may contain string, integer, long or double (real) values.
+These may contain string, integer, long or double (real) values as well as
+date, time, datetime or timedelta objects.
 ``columns`` is an optional tuple or list of column names to be passed on
 to the COPY command.
 The number of rows affected is returned.
diff --git a/ext/pgconn.c b/ext/pgconn.c
@@ -792,6 +792,7 @@ conn_inserttable(connObject *self, PyObject *args, PyObject *kwds)
 
     encoding = PQclientEncoding(self->cnx);
 
+    /* import datetime C API (this is not compatible with subinterpreters) */
     PyDateTime_IMPORT;
     if (PyErr_Occurred()) {
         return NULL; /* pass the error */
@@ -993,15 +994,9 @@ conn_inserttable(connObject *self, PyObject *args, PyObject *kwds)
                     Py_DECREF(s);
                 }
             }
-            else if (PyLong_Check(item)) {
-                PyObject *s = PyObject_Str(item);
-                const char *t = PyUnicode_AsUTF8(s);
-
-                ext_char_buffer_s(&buffer, t);
-                Py_DECREF(s);
-            }
-            else if (PyDate_Check(item) || PyDateTime_Check(item) ||
-                     PyTime_Check(item) || PyDelta_Check(item)) {
+            else if (PyLong_Check(item) || PyDate_Check(item) ||
+                     PyDateTime_Check(item) || PyTime_Check(item) ||
+                     PyDelta_Check(item)) {
                 PyObject *s = PyObject_Str(item);
                 const char *t = PyUnicode_AsUTF8(s);
 
