Merge branch 'develop' into refactor-syntax_unicode

runrevsebastien · runrevsebastien · commit ccfd9d9db028 · 2014-07-16T20:35:25.000+01:00
Conflicts:
	engine/src/desktop.cpp
	engine/src/mac-av-player.mm
	engine/src/mblalert.cpp
	engine/src/quicktime.cpp
diff --git a/Livecode.files b/Livecode.files
@@ -123,6 +123,7 @@ engine/src/deploy_sign.cpp
 engine/src/deploy_windows.cpp
 engine/src/deploysecurity.cpp
 engine/src/deploysecurity.h
+engine/src/desktop.cpp
 engine/src/dispatch.cpp
 engine/src/dispatch.h
 engine/src/dllst.cpp
diff --git a/docs/notes/bugfix-12055.md b/docs/notes/bugfix-12055.md
@@ -0,0 +1 @@
+# mobileVibrate not vibrating when passed a variable
diff --git a/docs/notes/bugfix-12481.md b/docs/notes/bugfix-12481.md
@@ -0,0 +1 @@
+# Various actions on players (such as hiding and showing) prevent it from working properly.
diff --git a/docs/notes/bugfix-12506.md b/docs/notes/bugfix-12506.md
@@ -0,0 +1 @@
+# Instability with manipulating QTKit players.
diff --git a/docs/notes/bugfix-12699.md b/docs/notes/bugfix-12699.md
@@ -0,0 +1 @@
+# Images don't appear or are clipped when printed to PDF
diff --git a/docs/notes/bugfix-12702.md b/docs/notes/bugfix-12702.md
@@ -0,0 +1 @@
+# Editing image then switching card and saving causes stack corruption
diff --git a/docs/notes/bugfix-12708.md b/docs/notes/bugfix-12708.md
@@ -1 +1 @@
-#  Pulldown menu submenus don't trigger menuPick
+# Submenus of popups don't send menuPick on selection.
diff --git a/docs/notes/bugfix-12747.md b/docs/notes/bugfix-12747.md
@@ -0,0 +1 @@
+# Shortcuts: the uncomment script shortcut cmd _ does not work
diff --git a/docs/notes/bugfix-12751.md b/docs/notes/bugfix-12751.md
@@ -0,0 +1,3 @@
+# QT-related features don't work.
+QT effects and sound recording will now work as long as 'dontUseQT' is set to false. In this case, the player will default to using QTKit.
+If you are submitting an app to the Mac AppStore, or wish to use AVFoundation player on 10.8 and above, ensure that dontUseQT is set to true in your startup handler, or before any code or stack which uses QT is run.
diff --git a/docs/notes/bugfix-12765.md b/docs/notes/bugfix-12765.md
@@ -0,0 +1 @@
+# The effective rect of a stack with vscroll > 0 is incorrect
diff --git a/docs/notes/bugfix-12773.md b/docs/notes/bugfix-12773.md
@@ -0,0 +1,2 @@
+# After dragging onto a field when LiveCode is in the background, focus doesn't work properly until reset.
+
diff --git a/docs/notes/bugfix-12780.md b/docs/notes/bugfix-12780.md
@@ -0,0 +1 @@
+# IDE stacks white rather than grey 
diff --git a/docs/notes/bugfix-12799.md b/docs/notes/bugfix-12799.md
@@ -0,0 +1 @@
+# On Mac, socketClosed messages are not sent immediately after timeout.
diff --git a/docs/notes/bugfix-12800.md b/docs/notes/bugfix-12800.md
@@ -0,0 +1 @@
+# Go stack in window [windowId] doesn't work.
diff --git a/docs/notes/bugfix-12809.md b/docs/notes/bugfix-12809.md
@@ -0,0 +1 @@
+# [[ Player ]] put the tracks of player 1 does not work properly
diff --git a/docs/notes/bugfix-12810.md b/docs/notes/bugfix-12810.md
@@ -0,0 +1 @@
+# [[Player]] controller icons not updated when keyboard shortcuts used to control playback
diff --git a/docs/notes/bugfix-12812.md b/docs/notes/bugfix-12812.md
@@ -0,0 +1 @@
+# [[Player]] loop goes to beginning of movie not selection start time when playSelection is true
diff --git a/docs/notes/bugfix-12818.md b/docs/notes/bugfix-12818.md
@@ -0,0 +1 @@
+# [[Player]] Selection thumbs should not be visible when selection duration is 0
diff --git a/docs/notes/feature-avfoundation_player.md b/docs/notes/feature-avfoundation_player.md
@@ -0,0 +1,12 @@
+# Multimedia on MacOS with AVFoundation 
+
+**What has changed?**
+
+The player object until now used QuickTime/QTKit APIs for audio and video playback. Since both QuickTime and QTKit have been deprecated by Apple, we have updated the player to use the new AVFoundation API. AVFoundation does not provide a controller for multimedia playback until OSX 10.9 and their new control bar is also missing some of the features provided by the QTKIt controller, which required us to implement our own controller to ensure backward compatibility. 
+We have added two new properties to the player object enabling you to customise the appearance of the controller:
+
+- The **hilitecolor** of a player is the color of the played area, the colour of the volume area, as well as the background color of a controller button when it is pressed.
+
+- The **forecolor** of a player is the color of the selected area. The selected area is the area between the selection handles.
+
+Note AVFoundation player is supported in OSX 10.8 and above. On systems running OSX 10.6 and 10.7, LiveCode continues to provide player functionality using the QTKit API.
diff --git a/engine/src/customprinter.cpp b/engine/src/customprinter.cpp
@@ -515,6 +515,8 @@ void MCCustomMetaContext::doimagemark(MCMark *p_mark)
 			bool t_mask, t_alpha;
 			t_mask = !MCGImageIsOpaque(p_mark->image.descriptor.image);
 			t_alpha = t_mask && MCGImageHasPartialTransparency(p_mark->image.descriptor.image);
+			// IM-2014-06-26: [[ Bug 12699 ]] Set image type appropriately.
+			t_image . type = t_alpha ? kMCCustomPrinterImageRawARGB : (t_mask ? kMCCustomPrinterImageRawMRGB : kMCCustomPrinterImageRawXRGB);
 			t_image . id = (uint32_t)(intptr_t)p_mark->image.descriptor.image;
 			t_image . data = t_raster.pixels;
 			t_image . data_size = t_raster.stride * t_img_height;
@@ -531,9 +533,10 @@ void MCCustomMetaContext::doimagemark(MCMark *p_mark)
 
 		// Compute the transform that is needed - this transform goes from image
 		// space to page space.
+		// IM-2014-06-26: [[ Bug 12699 ]] Rework to ensure transforms are applied in the correct order - page transform -> image offset -> image transform
 		MCGAffineTransform t_transform;
-		t_transform = MCGAffineTransformMakeScale(m_scale_x, m_scale_y);
-		t_transform = MCGAffineTransformTranslate(t_transform, m_translate_x + p_mark -> image . dx - p_mark -> image . sx, m_translate_y + p_mark -> image . dy - p_mark -> image . sy);
+		t_transform = MCGAffineTransformMake(m_scale_x, 0, 0, m_scale_y, m_translate_x, m_translate_y);
+		t_transform = MCGAffineTransformConcat(t_transform, MCGAffineTransformMakeTranslation(p_mark -> image . dx - p_mark -> image . sx, p_mark -> image . dy - p_mark -> image . sy));
 		if (p_mark -> image . descriptor . has_transform)
 			t_transform = MCGAffineTransformConcat(t_transform, p_mark -> image . descriptor . transform);
 
diff --git a/engine/src/desktop-dc.cpp b/engine/src/desktop-dc.cpp
@@ -411,11 +411,7 @@ void MCScreenDC::openwindow(Window w, Boolean override)
 	if (t_stack != nil)
 		t_parent = t_stack -> getparentwindow();
 		
-    // SN-2014-07-11: [[ Bug 12708 ]] Pulldown menu submenus don't trigger menuPick
-    //  We want a weak popup for the combo (being deleted each time it's not the target a click)
-	if (t_stack -> getmode() == WM_COMBO)
-        MCPlatformShowWindowAsCombo(w);
-    else if (t_stack -> getmode() != WM_SHEET)
+	if (t_stack -> getmode() != WM_SHEET)
 		MCPlatformShowWindow(w);
 	else
 		MCPlatformShowWindowAsSheet(w, t_parent);
@@ -471,9 +467,17 @@ uint4 MCScreenDC::dtouint4(Drawable d)
 	return t_id;
 }
 
-Boolean MCScreenDC::uint4towindow(uint4, Window &w)
+Boolean MCScreenDC::uint4towindow(uint4 p_id, Window &w)
 {
-	return False;
+    // MW-2014-07-15: [[ Bug 12800 ]] Map the windowId to a platform window if one exists.
+    MCPlatformWindowRef t_window;
+    
+    if (!MCPlatformGetWindowWithId(p_id, t_window))
+        return False;
+    
+    w = (Window)t_window;
+    
+	return True;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -842,6 +846,11 @@ Boolean MCScreenDC::wait(real8 duration, Boolean dispatch, Boolean anyevent)
 		if (HasRunloopActions())
 			t_sleep = MCMin(0.01, t_sleep);
 		
+        // MW-2014-07-16: [[ Bug 12799 ]] If polling sockets does something then don't wait for long.
+        extern Boolean MCS_handle_sockets();
+        if (MCS_handle_sockets())
+            t_sleep = 0.0;
+        
 		// Wait for t_sleep seconds and collect at most one event. If an event
 		// is collected and anyevent is True, then we are done.
 		if (MCPlatformWaitForEvent(t_sleep, dispatch == False) && anyevent)
diff --git a/engine/src/desktop-stack.cpp b/engine/src/desktop-stack.cpp
@@ -250,6 +250,14 @@ void MCStack::stop_externals()
 	
 	MCPlayer *tptr = MCplayers;
 	
+#ifdef FEATURE_PLATFORM_PLAYER
+    while(tptr != NULL)
+    {
+        if (tptr -> getstack() == this)
+            tptr -> playstop();
+        tptr = tptr -> getnextplayer();
+    }
+#else
 	while (tptr != NULL)
 	{
 		if (tptr->getstack() == this)
@@ -260,6 +268,7 @@ void MCStack::stop_externals()
 		else
 			tptr = tptr->getnextplayer();
 	}
+#endif
 	destroywindowshape();
 	
 	MClockmessages = oldlock;
diff --git a/engine/src/desktop.cpp b/engine/src/desktop.cpp
@@ -555,9 +555,12 @@ static void map_key_to_engine(MCPlatformKeyCode p_key_code, codepoint_t p_mapped
 {
     if (p_mapped_codepoint <= 0xffff)
 	{
-		uint16_t t_unicode_char;
-		t_unicode_char = p_mapped_codepoint & 0xffff;
+        uint16_t t_unicode_char;
         char_t t_native_char;
+
+        // SN-2014-07-11: [[ Bug 12747 ]] Shortcuts: the uncomment script shortcut cmd _ does not work
+        //  We want to take in account the unmapped char, since with the mapped one, Cmd discards the Shift modifier
+        t_unicode_char = p_unmapped_codepoint & 0xffff;
 		
 		if (MCUnicodeMapToNative(&t_unicode_char, 1, t_native_char))
 		{
diff --git a/engine/src/exec-interface-player.cpp b/engine/src/exec-interface-player.cpp
@@ -595,8 +595,6 @@ void MCPlayer::SetVisibility(MCExecContext& ctxt, uinteger_t part, bool setting,
 {
     uint4 oldflags = flags;
     MCObject::SetVisibility(ctxt, part, setting, visible);
-    if (flags != oldflags && !(flags & F_VISIBLE))
-        playstop();
     
     // SN-2014-07-03: [[ PlatformPlayer ]]
     // P_VISIBLE getter refactored to the MCPlayer implementations
diff --git a/engine/src/image.cpp b/engine/src/image.cpp
@@ -241,6 +241,10 @@ void MCImage::close()
 		endsel();
 	if (state & CS_MAGNIFY)
 		endmag(True);
+	
+	// IM-2014-06-26: [[ Bug 12702 ]] Make sure editing is finished when closing.
+	recompress();
+	
 	if (opened == 1 && m_image_opened)
 		closeimage();
 	MCControl::close();
diff --git a/engine/src/mac-av-player.mm b/engine/src/mac-av-player.mm
@@ -115,6 +115,7 @@ static CVReturn MyDisplayLinkCallback (CVDisplayLinkRef displayLink,
     CVDisplayLinkRef m_display_link;
     com_runrev_livecode_MCAVFoundationPlayerView *m_view;
     uint32_t m_selection_start, m_selection_finish;
+    uint32_t m_selection_duration;
     bool m_play_selection_only : 1;
     bool m_looping : 1;
     
@@ -308,7 +309,11 @@ - (void)setPlayer:(AVPlayer *)player
     }
     else
     {
-        [[m_player currentItem] seekToTime:kCMTimeZero toleranceBefore:kCMTimeZero toleranceAfter:kCMTimeZero];
+        // PM-2014-07-15: [[ Bug 12812 ]] Make sure we loop within start and finish time when playSelection is true 
+        if (m_play_selection_only)
+            [[m_player currentItem] seekToTime:CMTimeMake(m_selection_start, 1000) toleranceBefore:kCMTimeZero toleranceAfter:kCMTimeZero];
+        else
+            [[m_player currentItem] seekToTime:kCMTimeZero toleranceBefore:kCMTimeZero toleranceAfter:kCMTimeZero];
         
         if (m_offscreen)
             CVDisplayLinkStart(m_display_link);
@@ -357,7 +362,13 @@ - (void)setPlayer:(AVPlayer *)player
 void MCAVFoundationPlayer::SelectionChanged(void)
 {
     if (m_play_selection_only)
-        [[m_player currentItem] setForwardPlaybackEndTime:CMTimeMake(m_selection_finish, 1000)];
+    {
+        // PM-2014-07-15 [[ Bug 12818 ]] If the duration of the selection is 0 then the player ignores the selection
+        if (m_selection_duration != 0)
+            [[m_player currentItem] setForwardPlaybackEndTime:CMTimeMake(m_selection_finish, 1000)];
+        else
+            [[m_player currentItem] setForwardPlaybackEndTime:kCMTimeInvalid];
+    }
     else
         [[m_player currentItem] setForwardPlaybackEndTime:kCMTimeInvalid];
     
@@ -444,6 +455,8 @@ - (void)setPlayer:(AVPlayer *)player
     MCAVFoundationPlayer *t_player;
 	t_player = (MCAVFoundationPlayer *)ctxt;
     
+    if (!t_player -> m_frame_changed_pending)
+        return;
     // PM-2014-07-07: [[Bug 12746]] Removed code to make player display the first frame when a new movie is loaded
     //if (t_player -> m_loaded && !t_player -> IsPlaying())
         //return;
@@ -682,21 +695,36 @@ - (void)setPlayer:(AVPlayer *)player
 {
     if (m_offscreen && !CVDisplayLinkIsRunning(m_display_link))
         CVDisplayLinkStart(m_display_link);
-
-    if (m_finished && !m_play_selection_only)
+ 
+    // PM-2014-07-15 Various tweaks to handle all cases of playback
+    if (!m_play_selection_only)
     {
-        [m_player seekToTime:kCMTimeZero toleranceBefore:kCMTimeZero toleranceAfter:kCMTimeZero];
-        m_playing = true;
-        m_finished = false;
+        if (m_finished && CMTimeCompare(m_player . currentTime, m_player . currentItem . duration) >= 0)
+        {
+            [m_player seekToTime:kCMTimeZero toleranceBefore:kCMTimeZero toleranceAfter:kCMTimeZero];
+        }
     }
-
-    // put the thumb in the beginning of the selected area, if it is outside
-    if (m_play_selection_only && (CMTimeCompare(m_player . currentTime, CMTimeMake(m_selection_finish, 1000)) >= 0 || CMTimeCompare(m_player . currentTime, CMTimeMake(m_selection_start, 1000)) <= 0))
+    else
     {
-        [m_player seekToTime:CMTimeMake(m_selection_start, 1000) toleranceBefore:kCMTimeZero toleranceAfter:kCMTimeZero];
-
+        if (m_finished)
+        {
+            if (m_selection_duration > 0 && m_play_selection_only && (CMTimeCompare(m_player . currentTime, CMTimeMake(m_selection_finish, 1000)) >= 0 || CMTimeCompare(m_player . currentTime, CMTimeMake(m_selection_start, 1000)) <= 0))
+            {
+                [m_player seekToTime:CMTimeMake(m_selection_start, 1000) toleranceBefore:kCMTimeZero toleranceAfter:kCMTimeZero];
+                
+            }
+            
+            // PM-2014-07-15 [[ Bug 12818 ]] If the duration of the selection is 0 then the player ignores the selection
+            if (m_selection_duration == 0 && CMTimeCompare(m_player . currentTime, m_player . currentItem . duration) >= 0)
+            {
+                [m_player seekToTime:kCMTimeZero toleranceBefore:kCMTimeZero toleranceAfter:kCMTimeZero];
+            }
+            
+        }
     }
-
+    
+    m_playing = true;
+    m_finished = false;
     [m_player setRate:rate];
 }
 
@@ -810,7 +838,8 @@ - (void)setPlayer:(AVPlayer *)player
                 // PM-2014-07-09: [[ Bug 12761 ]] Make sure dragging the selection_start marker does not move the selection_finish marker
                 m_selection_start = m_selection_finish;
             }
-            
+            // PM-2014-07-15 [[ Bug 12818 ]] If the duration of the selection is 0 then the player ignores the selection
+            m_selection_duration = m_selection_finish - m_selection_start;
         }
             break;
 		case kMCPlatformPlayerPropertyFinishTime:
@@ -821,7 +850,8 @@ - (void)setPlayer:(AVPlayer *)player
             {
                 m_selection_finish = m_selection_start;
             }
-            
+            // PM-2014-07-15 [[ Bug 12818 ]] If the duration of the selection is 0 then the player ignores the selection
+            m_selection_duration = m_selection_finish - m_selection_start;
         }
             break;
 		case kMCPlatformPlayerPropertyPlayRate:
diff --git a/engine/src/mac-core.mm b/engine/src/mac-core.mm
@@ -836,6 +836,27 @@ void MCPlatformGetWindowAtPoint(MCPoint p_loc, MCPlatformWindowRef& r_window)
 		r_window = nil;
 }
 
+// MW-2014-07-15: [[ Bug 12800 ]] Map a window number to a platform window - if there is one.
+bool MCPlatformGetWindowWithId(uint32_t p_id, MCPlatformWindowRef& r_window)
+{
+    NSWindow *t_ns_window;
+    t_ns_window = [NSApp windowWithWindowNumber: p_id];
+    if (t_ns_window == nil)
+        return false;
+    
+    id t_delegate;
+    t_delegate = [t_ns_window delegate];
+    if (t_delegate == nil)
+        return false;
+    
+    if (![t_delegate isKindOfClass: [MCWindowDelegate class]])
+        return false;
+    
+    r_window = [(MCWindowDelegate *)t_delegate platformWindow];
+    
+    return true;
+}
+
 uint32_t MCPlatformGetEventTime(void)
 {
 	return [[NSApp currentEvent] timestamp] * 1000.0;
diff --git a/engine/src/mac-internal.h b/engine/src/mac-internal.h
@@ -67,6 +67,7 @@ class MCMacPlatformSurface;
 @interface com_runrev_livecode_MCWindow: NSWindow
 {
 	bool m_can_become_key : 1;
+    bool m_is_popup : 1;
     id m_monitor;
 }
 
@@ -400,8 +401,10 @@ class MCMacPlatformWindow: public MCPlatformWindow
 	void ProcessMousePress(NSInteger button, bool is_down);
 	void ProcessMouseScroll(CGFloat dx, CGFloat dy);
 	
-	void ProcessKeyDown(MCPlatformKeyCode key_code, codepoint_t unmapped_char, codepoint_t mapped_char);
-	void ProcessKeyUp(MCPlatformKeyCode key_code, codepoint_t unmapped_char, codepoint_t mapped_char);
+    // SN-2014-07-11: [[ Bug 12747 ]] Shortcuts: the uncomment script shortcut cmd _ does not work
+    // Changed parameters order to follow *KeyDown functions consistency
+	void ProcessKeyDown(MCPlatformKeyCode key_code, codepoint_t mapped_char, codepoint_t unmapped_char);
+	void ProcessKeyUp(MCPlatformKeyCode key_code, codepoint_t mapped_char, codepoint_t unmapped_char);
 	
 	void MapMCPointToNSPoint(MCPoint location, NSPoint& r_ns_location);
 	void MapNSPointToMCPoint(NSPoint location, MCPoint& r_mc_location);
@@ -416,9 +419,7 @@ class MCMacPlatformWindow: public MCPlatformWindow
 	virtual bool DoSetProperty(MCPlatformWindowProperty property, MCPlatformPropertyType type, const void *value);
 	virtual bool DoGetProperty(MCPlatformWindowProperty property, MCPlatformPropertyType type, void *r_value);
 	
-	virtual void DoShow(void);    
-    // SN-2014-07-11: [[ Bug 12708 ]] Pulldown menu submenus don't trigger menuPick
-    virtual void DoShowAsCombo(void);
+	virtual void DoShow(void);
 	virtual void DoShowAsSheet(MCPlatformWindowRef parent);
 	virtual void DoHide(void);
 	virtual void DoFocus(void);
diff --git a/engine/src/mac-player.mm b/engine/src/mac-player.mm
@@ -95,18 +95,16 @@
 extern MCAVFoundationPlayer *MCAVFoundationPlayerCreate(void);
 extern MCQTKitPlayer *MCQTKitPlayerCreate(void);
 extern uint4 MCmajorosversion;
+extern bool MCQTInit(void);
 
 void MCPlatformCreatePlayer(MCPlatformPlayerRef& r_player)
 {
-    // PM-2014-07-10: [[ Bug 12737 ]] For Mac OSX 10.7, use the old QTKit player
-    if (MCmajorosversion >= 0x1080)
-    {
+    // MW-2014-07-16: [[ QTSupport ]] If we manage to init QT (i.e. dontUseQT is false and
+    //   QT is available) then use QTKit, else use AVFoundation if 10.8 and above.
+    if (!MCQTInit() && MCmajorosversion >= 0x1080)
         r_player = (MCPlatformPlayerRef)MCAVFoundationPlayerCreate();
-    }
     else
-    {
         r_player = (MCPlatformPlayerRef)MCQTKitPlayerCreate();
-    }
 }
 
 void MCPlatformPlayerRetain(MCPlatformPlayerRef player)
diff --git a/engine/src/mac-qt-player.mm b/engine/src/mac-qt-player.mm
diff --git a/engine/src/mac-window.mm b/engine/src/mac-window.mm
diff --git a/engine/src/mblalert.cpp b/engine/src/mblalert.cpp
diff --git a/engine/src/mblhandlers.cpp b/engine/src/mblhandlers.cpp
diff --git a/engine/src/osxmisc.cpp b/engine/src/osxmisc.cpp
diff --git a/engine/src/platform-internal.h b/engine/src/platform-internal.h
diff --git a/engine/src/platform-window.cpp b/engine/src/platform-window.cpp
diff --git a/engine/src/platform.h b/engine/src/platform.h
diff --git a/engine/src/player-platform.cpp b/engine/src/player-platform.cpp
diff --git a/engine/src/quicktime.cpp b/engine/src/quicktime.cpp
diff --git a/engine/src/quicktime.stubs b/engine/src/quicktime.stubs
diff --git a/engine/src/stack.cpp b/engine/src/stack.cpp
diff --git a/revpdfprinter/src/revpdfprinter.cpp b/revpdfprinter/src/revpdfprinter.cpp

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# mobileVibrate not vibrating when passed a variable`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Various actions on players (such as hiding and showing) prevent it from working properly.`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Instability with manipulating QTKit players.`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Images don't appear or are clipped when printed to PDF`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Editing image then switching card and saving causes stack corruption`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-# Pulldown menu submenus don't trigger menuPick`
	`1`	`+# Submenus of popups don't send menuPick on selection.`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Shortcuts: the uncomment script shortcut cmd _ does not work`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+# QT-related features don't work.`
	`2`	`+QT effects and sound recording will now work as long as 'dontUseQT' is set to false. In this case, the player will default to using QTKit.`
	`3`	`+If you are submitting an app to the Mac AppStore, or wish to use AVFoundation player on 10.8 and above, ensure that dontUseQT is set to true in your startup handler, or before any code or stack which uses QT is run.`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# The effective rect of a stack with vscroll > 0 is incorrect`