Skip to content

Commit 18df560

Browse files
authored
(chore): Bucket maintenance (#433)
* (chore): Update issue templates * (chore): Update bin * (chore): Add workflows
1 parent 2024909 commit 18df560

14 files changed

Lines changed: 203 additions & 45 deletions

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
/.github/workflows/ @ScoopInstaller/maintainers
Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
---
2+
name: "Package Request"
3+
about: "I have a suggestion for a package (and may want to implement it)!"
4+
title: "[Request] "
5+
labels: "package-request"
6+
---
7+
8+
<!--
9+
By opening this issue you confirm that you have searched for similar issues/PRs here already.
10+
Failing to do so will most likely result in closing of this issue without any explanation.
11+
Incomplete form details below might also result in closing of the issue.
12+
-->
13+
14+
## Package Request
15+
16+
### Criteria
17+
18+
For a package to be acceptable in the Java bucket, it should be:
19+
20+
<!-- All items need to be checked. -->
21+
22+
- [ ] a runtime environment or software development kit for Java
23+
- [ ] a reasonably well-known and widely used developer tool (e.g. if it's a GitHub project, it should have at least 500 stars and 150 forks)
24+
- [ ] the latest stable version of the program
25+
- [ ] the full version i.e. not a trial version
26+
- [ ] a fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)
27+
- [ ] downloadable without having to sign in or use user-dependant cookies
28+
29+
### Information
30+
31+
**Name:** [name of new package]
32+
33+
**Description:** [clear and concise details of what it is]
34+
35+
**Homepage:** [a URL/link]
36+
37+
**Download link(s):** [URL(s)/link(s)]
38+
39+
**Some indication of popularity/repute:** [GitHub stars/software reviews etc.]
40+
41+
**License:** [SPDX license identifier]
Lines changed: 47 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,56 @@
11
---
2-
name: Bug report
3-
about: Create a report to help us improve
4-
title: ''
5-
labels: bug
6-
assignees: ''
7-
2+
name: "Bug report"
3+
about: "Create a report to help us improve"
4+
title: ""
5+
labels: "bug"
86
---
97

10-
**Troubleshooting before submitting**
11-
- [ ] Ran `scoop checkup` with no found problems?
12-
- [ ] Read the [wiki](https://github.com/lukesampson/scoop/wiki/Java) relevant for the manifest being installed?
13-
- [ ] Checked for [duplicate issues](https://github.com/ScoopInstaller/Java/issues?q=is%3Aissue), included closed ones?
14-
- [ ] Checked with [main scoop repo](https://github.com/lukesampson/scoop/issues) for related issues
8+
<!--
9+
By opening this issue you confirm that you have searched for similar issues/PRs here already.
10+
Failing to do so will most likely result in closing of this issue without any explanation.
11+
Incomplete form details below might also result in closing of the issue.
12+
-->
13+
14+
## Bug Report
15+
16+
**Package Name:** [name of package which has bug(s)]
17+
18+
### Current Behaviour
19+
20+
<!-- A clear and concise description of the behaviour. -->
21+
22+
### Expected Behaviour
23+
24+
<!-- A clear and concise description of what you expected to happen. -->
1525

16-
**Describe the bug**
17-
A clear and concise description of what the bug is.
26+
### Additional context/output
1827

19-
**To Reproduce**
20-
Steps to reproduce the behavior:
28+
<!-- Add any other context about the problem here. If applicable, paste terminal output here to help explain. -->
2129

22-
**Expected behavior**
23-
A clear and concise description of what you expected to happen.
30+
### Possible Solution
2431

25-
**Screenshots**
26-
If applicable, add screenshots to help explain your problem.
32+
<!--- Only if you have suggestions on a fix for the bug -->
2733

28-
**Desktop (please complete the following information):**
29-
- Windows Version:
30-
- Powershell Version:
34+
### System details
3135

32-
**Additional context**
33-
Add any other context about the problem here.
36+
**Windows version:** [e.g. 7, 8, 10]
37+
38+
**OS architecture:** [e.g. 32bit, 64bit]
39+
40+
**PowerShell version:** [output of `"$($PSVersionTable.PSVersion)"`]
41+
42+
**Additional software:** [(optional) e.g. ConEmu, Git]
43+
44+
#### Scoop Configuration
45+
<!-- Can be found in ~/.config/scoop/config.json -->
46+
47+
```json
48+
//# Your configuration here
49+
```
50+
51+
#### Troubleshooting before submitting
52+
53+
- [ ] Ran `scoop checkup` with no found problems?
54+
- [ ] Read the [wiki](https://github.com/ScoopInstaller/Java/wiki) relevant for the manifest being installed?
55+
- [ ] Checked for [duplicate issues](https://github.com/ScoopInstaller/Java/issues?q=is%3Aissue), included closed ones?
56+
- [ ] Checked with [main scoop repo](https://github.com/ScoopInstaller/Scoop/issues) for related issues

.github/workflows/ci.yml

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
name: Tests
2+
3+
on:
4+
pull_request:
5+
push:
6+
workflow_dispatch:
7+
8+
jobs:
9+
test_powershell:
10+
name: WindowsPowerShell
11+
runs-on: windows-latest
12+
steps:
13+
- name: Checkout Bucket
14+
uses: actions/checkout@v2
15+
with:
16+
fetch-depth: 2
17+
path: 'my_bucket'
18+
- name: Checkout Scoop
19+
uses: actions/checkout@v2
20+
with:
21+
repository: ScoopInstaller/Scoop
22+
path: 'scoop_core'
23+
- name: Init and Test
24+
shell: powershell
25+
run: |
26+
$env:SCOOP_HOME="$(Convert-Path '.\scoop_core')"
27+
.\scoop_core\test\bin\init.ps1
28+
.\my_bucket\bin\test.ps1
29+
test_pwsh:
30+
name: PowerShell
31+
runs-on: windows-latest
32+
steps:
33+
- name: Checkout Bucket
34+
uses: actions/checkout@v2
35+
with:
36+
fetch-depth: 2
37+
path: 'my_bucket'
38+
- name: Checkout Scoop
39+
uses: actions/checkout@v2
40+
with:
41+
repository: ScoopInstaller/Scoop
42+
path: 'scoop_core'
43+
- name: Init and Test
44+
shell: pwsh
45+
run: |
46+
$env:SCOOP_HOME="$(Convert-Path '.\scoop_core')"
47+
.\scoop_core\test\bin\init.ps1
48+
.\my_bucket\bin\test.ps1
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
on:
2+
issue_comment:
3+
types: [ created ]
4+
name: Commented Pull Request
5+
jobs:
6+
pullRequestHandler:
7+
name: PullRequestHandler
8+
runs-on: windows-latest
9+
steps:
10+
- uses: actions/checkout@main
11+
- name: PullRequestHandler
12+
uses: ScoopInstaller/GithubActions@main
13+
if: startsWith(github.event.comment.body, '/verify')
14+
env:
15+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/issues.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
on:
2+
issues:
3+
types: [ opened, labeled ]
4+
name: Issues
5+
jobs:
6+
issueHandler:
7+
name: IssueHandler
8+
runs-on: windows-latest
9+
steps:
10+
- uses: actions/checkout@main
11+
- name: IssueHandler
12+
uses: ScoopInstaller/GithubActions@main
13+
if: github.event.action == 'opened' || (github.event.action == 'labeled' && contains(github.event.issue.labels.*.name, 'verify'))
14+
env:
15+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pull_request.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
on:
2+
pull_request:
3+
types: [ opened ]
4+
name: Pull Requests
5+
jobs:
6+
pullRequestHandler:
7+
name: PullRequestHandler
8+
runs-on: windows-latest
9+
steps:
10+
- uses: actions/checkout@main
11+
- name: PullRequestHandler
12+
uses: ScoopInstaller/GithubActions@main
13+
env:
14+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
# Scoop Java [![Build Status](https://ci.appveyor.com/api/projects/status/8t3ut3ss93jnm3i8?svg=true)](https://ci.appveyor.com/project/se35710/scoop-java "Build Status") [![Repo size](https://img.shields.io/github/repo-size/scoopinstaller/Java.svg?style=flat-square)](https://github.com/scoopinstaller/Java) [![Mentioned in Awesome Scoop](https://awesome.re/mentioned-badge.svg)](https://github.com/scoopinstaller/awesome-scoop)
1+
# Scoop Java [![Tests](https://github.com/ScoopInstaller/Java/actions/workflows/ci.yml/badge.svg)](https://github.com/ScoopInstaller/Java/actions/workflows/ci.yml) [![Repo size](https://img.shields.io/github/repo-size/scoopinstaller/Java.svg?style=flat-square)](https://github.com/scoopinstaller/Java) [![Mentioned in Awesome Scoop](https://awesome.re/mentioned-badge.svg)](https://github.com/scoopinstaller/awesome-scoop)
22
<!-- [![Excavator](https://github.com/ScoopInstaller/Java/actions/workflows/excavator.yml/badge.svg)](https://github.com/ScoopInstaller/Java/actions/workflows/excavator.yml) -->
33

44
A bucket for [Scoop](https://scoop.sh), for [Oracle Java](https://www.oracle.com/java/), [OpenJDK](https://openjdk.java.net), [Eclipse Temurin](https://adoptium.net), [IBM Semeru](https://developer.ibm.com/languages/java/semeru-runtimes), [Zulu](https://www.azul.com/products/zulu-community), [ojdkbuild](https://github.com/ojdkbuild/ojdkbuild), [Amazon Corretto](https://aws.amazon.com/corretto), [BellSoft Liberica](https://bell-sw.com/java), [SapMachine](https://sap.github.io/SapMachine) and [Microsoft JDK](https://www.microsoft.com/openjdk).
55

66
To make it easy to install apps from this bucket, run
77
`scoop bucket add java`
88

9-
For more information, read the [wiki](https://github.com/ScoopInstaller/Scoop/wiki/Java).
9+
For more information, read the [wiki](https://github.com/ScoopInstaller/Java/wiki).

bin/auto-pr.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
param(
22
# overwrite upstream param
3-
[String]$upstream = "scoopinstaller/Java:master"
3+
[String]$upstream = "ScoopInstaller/Java:master"
44
)
55

6-
if(!$env:SCOOP_HOME) { $env:SCOOP_HOME = resolve-path (split-path (split-path (scoop which scoop))) }
6+
if(!$env:SCOOP_HOME) { $env:SCOOP_HOME = Resolve-Path (scoop prefix scoop) }
77
$autopr = "$env:SCOOP_HOME/bin/auto-pr.ps1"
8-
$dir = "$psscriptroot/../bucket" # checks the parent dir
9-
Invoke-Expression -command "$autopr -dir $dir -upstream $upstream $($args | ForEach-Object { "$_ " })"
8+
$dir = "$PSScriptRoot/../bucket" # checks the parent dir
9+
Invoke-Expression -command "& '$autopr' -dir '$dir' -upstream $upstream $($args | ForEach-Object { "$_ " })"

bin/checkurls.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
if(!$env:SCOOP_HOME) { $env:SCOOP_HOME = resolve-path (split-path (split-path (scoop which scoop))) }
1+
if(!$env:SCOOP_HOME) { $env:SCOOP_HOME = Resolve-Path (scoop prefix scoop) }
22
$checkurls = "$env:SCOOP_HOME/bin/checkurls.ps1"
3-
$dir = "$psscriptroot/../bucket" # checks the parent dir
4-
Invoke-Expression -command "$checkurls -dir $dir $($args | ForEach-Object { "$_ " })"
3+
$dir = "$PSScriptRoot/../bucket" # checks the parent dir
4+
Invoke-Expression -command "& '$checkurls' -dir '$dir' $($args | ForEach-Object { "$_ " })"

0 commit comments

Comments
 (0)