forked from 1jehuang/jcode
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathreload_tests.rs
More file actions
569 lines (521 loc) · 18.6 KB
/
Copy pathreload_tests.rs
File metadata and controls
569 lines (521 loc) · 18.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
use super::{
graceful_shutdown_sessions, graceful_shutdown_sessions_with_timeout,
persist_reload_recovery_intents, receive_reload_signal,
};
use crate::server::{ReloadSignal, SwarmEvent, SwarmEventType, SwarmMember};
use jcode_agent_runtime::InterruptSignal;
use std::collections::HashMap;
use std::sync::Arc;
use std::time::Instant;
use tokio::sync::{RwLock, broadcast, mpsc, watch};
fn set_member_status(members: &mut HashMap<String, SwarmMember>, session_id: &str, status: &str) {
assert!(
members.contains_key(session_id),
"missing test member {session_id}"
);
if let Some(member) = members.get_mut(session_id) {
member.status = status.to_string();
}
}
fn member(session_id: &str, status: &str) -> SwarmMember {
let (event_tx, _event_rx) = mpsc::unbounded_channel();
SwarmMember {
session_id: session_id.to_string(),
event_tx,
event_txs: HashMap::new(),
working_dir: None,
swarm_id: None,
swarm_enabled: false,
status: status.to_string(),
detail: None,
friendly_name: None,
report_back_to_session_id: None,
role: "agent".to_string(),
joined_at: Instant::now(),
last_status_change: Instant::now(),
is_headless: false,
}
}
#[tokio::test]
async fn receive_reload_signal_consumes_already_pending_value() {
let (tx, mut rx) = watch::channel(None::<ReloadSignal>);
tx.send(Some(ReloadSignal {
hash: "abc1234".to_string(),
triggering_session: Some("sess-1".to_string()),
prefer_selfdev_binary: true,
request_id: "reload-1".to_string(),
}))
.expect("send pending reload signal");
let signal = tokio::time::timeout(
std::time::Duration::from_millis(100),
receive_reload_signal(&mut rx),
)
.await
.expect("pending signal should be observed immediately")
.expect("channel should still be open");
assert_eq!(signal.hash, "abc1234");
assert_eq!(signal.triggering_session.as_deref(), Some("sess-1"));
assert!(signal.prefer_selfdev_binary);
assert_eq!(signal.request_id, "reload-1");
}
#[tokio::test]
async fn receive_reload_signal_waits_for_future_value_when_initially_empty() {
let (tx, mut rx) = watch::channel(None::<ReloadSignal>);
let waiter = tokio::spawn(async move { receive_reload_signal(&mut rx).await });
tokio::time::sleep(std::time::Duration::from_millis(20)).await;
tx.send(Some(ReloadSignal {
hash: "def5678".to_string(),
triggering_session: Some("sess-2".to_string()),
prefer_selfdev_binary: false,
request_id: "reload-2".to_string(),
}))
.expect("send future reload signal");
let signal = tokio::time::timeout(std::time::Duration::from_millis(100), waiter)
.await
.expect("future signal should wake waiter")
.expect("waiter task should succeed")
.expect("channel should still be open");
assert_eq!(signal.hash, "def5678");
assert_eq!(signal.triggering_session.as_deref(), Some("sess-2"));
assert!(!signal.prefer_selfdev_binary);
assert_eq!(signal.request_id, "reload-2");
}
#[test]
fn persist_reload_recovery_intents_records_running_peer_recovery() -> anyhow::Result<()> {
let _guard = crate::storage::lock_test_env();
let temp_home = tempfile::TempDir::new()?;
let prev_home = std::env::var_os("JCODE_HOME");
crate::env::set_var("JCODE_HOME", temp_home.path());
let runtime = tokio::runtime::Builder::new_current_thread()
.enable_all()
.build()?;
let swarm_members = Arc::new(RwLock::new(HashMap::from([
("initiator".to_string(), member("initiator", "running")),
("peer".to_string(), member("peer", "running")),
("idle".to_string(), member("idle", "ready")),
])));
runtime.block_on(persist_reload_recovery_intents(
"reload-store-test",
&swarm_members,
Some("initiator"),
));
let peer_directive = crate::server::reload_recovery::claim_pending_for_session("peer")
.expect("claim peer recovery")
.expect("peer recovery intent should exist");
assert!(
peer_directive
.continuation_message
.contains("interrupted by a server reload")
);
assert!(
crate::server::reload_recovery::claim_pending_for_session("idle")
.expect("claim idle recovery")
.is_none(),
"idle sessions should not get reload recovery intents"
);
assert!(
crate::server::reload_recovery::claim_pending_for_session("initiator")
.expect("claim initiator recovery")
.is_none(),
"initiator without selfdev reload context should not get a generic interrupted-peer intent"
);
if let Some(prev_home) = prev_home {
crate::env::set_var("JCODE_HOME", prev_home);
} else {
crate::env::remove_var("JCODE_HOME");
}
Ok(())
}
#[tokio::test]
async fn graceful_shutdown_sessions_signals_all_running_sessions_including_initiator() {
let sessions = Arc::new(RwLock::new(HashMap::new()));
let swarm_members = Arc::new(RwLock::new(HashMap::from([
("initiator".to_string(), member("initiator", "running")),
("peer".to_string(), member("peer", "running")),
])));
let initiator_signal = InterruptSignal::new();
let peer_signal = InterruptSignal::new();
let shutdown_signals = Arc::new(RwLock::new(HashMap::from([
("initiator".to_string(), initiator_signal.clone()),
("peer".to_string(), peer_signal.clone()),
])));
let (swarm_event_tx, _) = broadcast::channel(8);
let swarm_members_for_task = swarm_members.clone();
let swarm_event_tx_for_task = swarm_event_tx.clone();
let checkpoint_task = tokio::spawn(async move {
tokio::task::yield_now().await;
{
let mut members = swarm_members_for_task.write().await;
set_member_status(&mut members, "initiator", "ready");
set_member_status(&mut members, "peer", "ready");
}
let _ = swarm_event_tx_for_task.send(SwarmEvent {
id: 1,
session_id: "initiator".to_string(),
session_name: None,
swarm_id: None,
event: SwarmEventType::StatusChange {
old_status: "running".to_string(),
new_status: "ready".to_string(),
},
timestamp: Instant::now(),
absolute_time: std::time::SystemTime::now(),
});
let _ = swarm_event_tx_for_task.send(SwarmEvent {
id: 2,
session_id: "peer".to_string(),
session_name: None,
swarm_id: None,
event: SwarmEventType::StatusChange {
old_status: "running".to_string(),
new_status: "ready".to_string(),
},
timestamp: Instant::now(),
absolute_time: std::time::SystemTime::now(),
});
});
graceful_shutdown_sessions(
&sessions,
&swarm_members,
&shutdown_signals,
&swarm_event_tx,
None,
)
.await;
checkpoint_task.await.expect("checkpoint task");
assert!(
initiator_signal.is_set(),
"initiating selfdev session should also be interrupted so reload tool cannot hang"
);
assert!(
peer_signal.is_set(),
"other running sessions should be interrupted too"
);
}
#[tokio::test]
async fn graceful_shutdown_sessions_does_not_wait_for_triggering_session_checkpoint() {
let sessions = Arc::new(RwLock::new(HashMap::new()));
let swarm_members = Arc::new(RwLock::new(HashMap::from([
("initiator".to_string(), member("initiator", "running")),
("peer".to_string(), member("peer", "running")),
])));
let initiator_signal = InterruptSignal::new();
let peer_signal = InterruptSignal::new();
let shutdown_signals = Arc::new(RwLock::new(HashMap::from([
("initiator".to_string(), initiator_signal.clone()),
("peer".to_string(), peer_signal.clone()),
])));
let (swarm_event_tx, _) = broadcast::channel(8);
let swarm_members_for_task = swarm_members.clone();
let swarm_event_tx_for_task = swarm_event_tx.clone();
let checkpoint_task = tokio::spawn(async move {
tokio::time::sleep(std::time::Duration::from_millis(50)).await;
{
let mut members = swarm_members_for_task.write().await;
set_member_status(&mut members, "peer", "ready");
}
let _ = swarm_event_tx_for_task.send(SwarmEvent {
id: 1,
session_id: "peer".to_string(),
session_name: None,
swarm_id: None,
event: SwarmEventType::StatusChange {
old_status: "running".to_string(),
new_status: "ready".to_string(),
},
timestamp: Instant::now(),
absolute_time: std::time::SystemTime::now(),
});
});
tokio::time::timeout(
std::time::Duration::from_secs(1),
graceful_shutdown_sessions(
&sessions,
&swarm_members,
&shutdown_signals,
&swarm_event_tx,
Some("initiator"),
),
)
.await
.expect("reload shutdown should not wait for triggering session");
checkpoint_task.await.expect("checkpoint task");
assert!(
initiator_signal.is_set(),
"triggering session should still receive graceful shutdown signal"
);
assert!(
peer_signal.is_set(),
"peer session should still receive graceful shutdown signal"
);
assert_eq!(
swarm_members
.read()
.await
.get("initiator")
.expect("initiator")
.status,
"running",
"initiator may remain running without blocking reload"
);
}
#[tokio::test]
async fn graceful_shutdown_sessions_skips_idle_sessions() {
let sessions = Arc::new(RwLock::new(HashMap::new()));
let swarm_members = Arc::new(RwLock::new(HashMap::from([(
"idle".to_string(),
member("idle", "ready"),
)])));
let idle_signal = InterruptSignal::new();
let shutdown_signals = Arc::new(RwLock::new(HashMap::from([(
"idle".to_string(),
idle_signal.clone(),
)])));
let (swarm_event_tx, _) = broadcast::channel(8);
graceful_shutdown_sessions(
&sessions,
&swarm_members,
&shutdown_signals,
&swarm_event_tx,
None,
)
.await;
assert!(
!idle_signal.is_set(),
"idle sessions should not be interrupted during reload"
);
}
#[tokio::test]
async fn graceful_shutdown_sessions_does_not_wait_on_running_sessions_without_signal() {
let sessions = Arc::new(RwLock::new(HashMap::new()));
let swarm_members = Arc::new(RwLock::new(HashMap::from([(
"orphan_running".to_string(),
member("orphan_running", "running"),
)])));
let shutdown_signals = Arc::new(RwLock::new(HashMap::new()));
let (swarm_event_tx, _) = broadcast::channel(8);
let started = Instant::now();
graceful_shutdown_sessions(
&sessions,
&swarm_members,
&shutdown_signals,
&swarm_event_tx,
None,
)
.await;
assert!(
started.elapsed() < std::time::Duration::from_millis(100),
"running sessions without shutdown signals should not consume the reload grace period"
);
}
#[tokio::test]
async fn graceful_shutdown_sessions_waits_until_target_status_change_arrives() {
let sessions = Arc::new(RwLock::new(HashMap::new()));
let swarm_members = Arc::new(RwLock::new(HashMap::from([(
"target".to_string(),
member("target", "running"),
)])));
let signal = InterruptSignal::new();
let shutdown_signals = Arc::new(RwLock::new(HashMap::from([(
"target".to_string(),
signal.clone(),
)])));
let (swarm_event_tx, _) = broadcast::channel(8);
let mut waiter = tokio::spawn({
let sessions = sessions.clone();
let swarm_members = swarm_members.clone();
let shutdown_signals = shutdown_signals.clone();
let swarm_event_tx = swarm_event_tx.clone();
async move {
graceful_shutdown_sessions(
&sessions,
&swarm_members,
&shutdown_signals,
&swarm_event_tx,
None,
)
.await;
}
});
tokio::time::sleep(std::time::Duration::from_millis(50)).await;
assert!(
signal.is_set(),
"running target should be interrupted promptly"
);
assert!(
tokio::time::timeout(std::time::Duration::from_millis(50), &mut waiter)
.await
.is_err(),
"reload shutdown should stay pending until target leaves running"
);
{
let mut members = swarm_members.write().await;
set_member_status(&mut members, "target", "ready");
}
let _ = swarm_event_tx.send(SwarmEvent {
id: 1,
session_id: "target".to_string(),
session_name: None,
swarm_id: None,
event: SwarmEventType::StatusChange {
old_status: "running".to_string(),
new_status: "ready".to_string(),
},
timestamp: Instant::now(),
absolute_time: std::time::SystemTime::now(),
});
tokio::time::timeout(std::time::Duration::from_secs(1), waiter)
.await
.expect("waiter should complete after target checkpoint")
.expect("waiter task should succeed");
}
#[tokio::test]
async fn graceful_shutdown_sessions_ignores_unrelated_events_until_target_leaves() {
let sessions = Arc::new(RwLock::new(HashMap::new()));
let swarm_members = Arc::new(RwLock::new(HashMap::from([
("target".to_string(), member("target", "running")),
("other".to_string(), member("other", "running")),
])));
let signal = InterruptSignal::new();
let shutdown_signals = Arc::new(RwLock::new(HashMap::from([("target".to_string(), signal)])));
let (swarm_event_tx, _) = broadcast::channel(8);
let mut waiter = tokio::spawn({
let sessions = sessions.clone();
let swarm_members = swarm_members.clone();
let shutdown_signals = shutdown_signals.clone();
let swarm_event_tx = swarm_event_tx.clone();
async move {
graceful_shutdown_sessions(
&sessions,
&swarm_members,
&shutdown_signals,
&swarm_event_tx,
None,
)
.await;
}
});
tokio::time::sleep(std::time::Duration::from_millis(20)).await;
{
let mut members = swarm_members.write().await;
set_member_status(&mut members, "other", "ready");
}
let _ = swarm_event_tx.send(SwarmEvent {
id: 1,
session_id: "other".to_string(),
session_name: None,
swarm_id: None,
event: SwarmEventType::StatusChange {
old_status: "running".to_string(),
new_status: "ready".to_string(),
},
timestamp: Instant::now(),
absolute_time: std::time::SystemTime::now(),
});
assert!(
tokio::time::timeout(std::time::Duration::from_millis(50), &mut waiter)
.await
.is_err(),
"unrelated status changes should not unblock reload shutdown"
);
{
let mut members = swarm_members.write().await;
set_member_status(&mut members, "target", "stopped");
}
let _ = swarm_event_tx.send(SwarmEvent {
id: 2,
session_id: "target".to_string(),
session_name: None,
swarm_id: None,
event: SwarmEventType::StatusChange {
old_status: "running".to_string(),
new_status: "stopped".to_string(),
},
timestamp: Instant::now(),
absolute_time: std::time::SystemTime::now(),
});
tokio::time::timeout(std::time::Duration::from_secs(1), waiter)
.await
.expect("waiter should complete after target transition")
.expect("waiter task should succeed");
}
#[tokio::test]
async fn graceful_shutdown_sessions_treats_member_left_as_unblocked() {
let sessions = Arc::new(RwLock::new(HashMap::new()));
let swarm_members = Arc::new(RwLock::new(HashMap::from([(
"target".to_string(),
member("target", "running"),
)])));
let signal = InterruptSignal::new();
let shutdown_signals = Arc::new(RwLock::new(HashMap::from([("target".to_string(), signal)])));
let (swarm_event_tx, _) = broadcast::channel(8);
let waiter = tokio::spawn({
let sessions = sessions.clone();
let swarm_members = swarm_members.clone();
let shutdown_signals = shutdown_signals.clone();
let swarm_event_tx = swarm_event_tx.clone();
async move {
graceful_shutdown_sessions(
&sessions,
&swarm_members,
&shutdown_signals,
&swarm_event_tx,
None,
)
.await;
}
});
tokio::time::sleep(std::time::Duration::from_millis(20)).await;
{
let mut members = swarm_members.write().await;
members.remove("target");
}
let _ = swarm_event_tx.send(SwarmEvent {
id: 1,
session_id: "target".to_string(),
session_name: None,
swarm_id: None,
event: SwarmEventType::MemberChange {
action: "left".to_string(),
},
timestamp: Instant::now(),
absolute_time: std::time::SystemTime::now(),
});
tokio::time::timeout(std::time::Duration::from_secs(1), waiter)
.await
.expect("waiter should complete after member leaves")
.expect("waiter task should succeed");
}
#[tokio::test]
async fn graceful_shutdown_sessions_times_out_and_proceeds() {
let sessions = Arc::new(RwLock::new(HashMap::new()));
let swarm_members = Arc::new(RwLock::new(HashMap::from([(
"target".to_string(),
member("target", "running"),
)])));
let signal = InterruptSignal::new();
let shutdown_signals = Arc::new(RwLock::new(HashMap::from([(
"target".to_string(),
signal.clone(),
)])));
let (swarm_event_tx, _) = broadcast::channel(8);
let started = Instant::now();
graceful_shutdown_sessions_with_timeout(
&sessions,
&swarm_members,
&shutdown_signals,
&swarm_event_tx,
std::time::Duration::from_millis(50),
None,
)
.await;
assert!(
signal.is_set(),
"running target should still be signaled promptly"
);
assert!(
started.elapsed() >= std::time::Duration::from_millis(50)
&& started.elapsed() < std::time::Duration::from_millis(250),
"graceful shutdown should honor the timeout instead of waiting indefinitely"
);
}