Fixed visualpython#256 : [BUG] Scrolling Issue with iloc in Subset App

Minku-Koo · Minku-Koo · commit cfbc858f8f60 · 2024-01-31T21:06:17.000+09:00
When iloc is selected in Subset app
- Fixes incorrect indexing issue
- Resolves scrollbar being fixed downwards, preventing number clicking and scrolling up.
diff --git a/visualpython/js/m_apps/Subset.js b/visualpython/js/m_apps/Subset.js
@@ -343,6 +343,9 @@ define([
             $(this.wrapSelector('.select-row .vp-ds-select-box.left')).on('scroll', function() {
                 if ($(this).scrollTop() + $(this).innerHeight() >= ($(this)[0].scrollHeight - 2)) {
                     let scrollPos = $(this).scrollTop();
+                    if (that.state.rowLimit > that.state.rowList.length){
+                        return; // Prevents scroll from being fixed downwards
+                    }
                     let start = that.state.rowLimit;
                     let end = start + 10;
                     let subsetVariable = com_util.formatString('{0}.iloc[{1}:{2}]', that.state.pandasObject, start, end);
@@ -361,9 +364,9 @@ define([
                             rowList = rowList.map(function (x) {
                                 return {
                                     ...x,
-                                    label: x.location + '',
-                                    value: x.location + '',
-                                    code: x.location + '',
+                                    label: x.label + '',
+                                    value: x.value + '',
+                                    code: x.code + '',
                                 };
                             });
                         }
