Skip to content

Commit 2872526

Browse files
kranthipoturajuKranthi Poturajusakethpanugantibrunoborges
authored
docs(action): fix missing required or default fields (#1007)
- Add required: false to java-version, java-version-file, job-status, and token, which had defaults or were optional but lacked the explicit flag - Add default: '' to gpg-private-key to match its stated description - Fix java-version-file description: the input accepts .java-version, .tool-versions, and .sdkmanrc, not only .java-version - Fix gpg-passphrase description: GPG_PASSPHRASE is only defaulted when gpg-private-key is provided, not unconditionally Co-authored-by: Kranthi Poturaju <Kranthi.Poturaju1@aexp.com> Co-authored-by: Panuganti Saketh <sakethpanuganti@gmail.com> Co-authored-by: Bruno Borges <bruno.borges@gmail.com>
1 parent bb8b13a commit 2872526

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

action.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@ author: 'GitHub'
55
inputs:
66
java-version:
77
description: 'The Java version to set up. Takes a whole or semver Java version. See examples of supported syntax in README file'
8+
required: false
89
java-version-file:
9-
description: 'The path to the `.java-version` file. See examples of supported syntax in README file'
10+
description: 'The path to a file containing the Java version to set up (.java-version, .tool-versions, .sdkmanrc). Used when java-version is not set. See examples of supported syntax in README file'
11+
required: false
1012
distribution:
1113
description: 'Java distribution. See the list of supported distributions in README file'
1214
required: true
@@ -49,9 +51,9 @@ inputs:
4951
gpg-private-key:
5052
description: 'GPG private key to import. Default is empty string.'
5153
required: false
54+
default: ''
5255
gpg-passphrase:
53-
description: 'Environment variable name for the GPG private key passphrase. Default is
54-
$GPG_PASSPHRASE.'
56+
description: 'Environment variable name for the GPG private key passphrase. Defaults to GPG_PASSPHRASE when gpg-private-key is set; ignored otherwise.'
5557
required: false
5658
cache:
5759
description: 'Name of the build platform to cache dependencies. It can be "maven", "gradle" or "sbt".'
@@ -61,9 +63,11 @@ inputs:
6163
required: false
6264
job-status:
6365
description: 'Workaround to pass job status to post job step. This variable is not intended for manual setting'
66+
required: false
6467
default: ${{ job.status }}
6568
token:
6669
description: The token used to authenticate when fetching version manifests hosted on github.com, such as for the Microsoft Build of OpenJDK. When running this action on github.com, the default value is sufficient. When running on GHES, you can pass a personal access token for github.com if you are experiencing rate limiting.
70+
required: false
6771
default: ${{ github.server_url == 'https://github.com' && github.token || '' }}
6872
mvn-toolchain-id:
6973
description: 'Name of Maven Toolchain ID if the default name of "${distribution}_${java-version}" is not wanted. See examples of supported syntax in Advanced Usage file'

0 commit comments

Comments
 (0)