fix: Fix issues found by Dart analyzer

kevmoo · kevmoo · commit 957384ceebba · 2015-04-15T20:58:29.000-07:00
diff --git a/modules/angular2/globals.dart b/modules/angular2/globals.dart
@@ -1,2 +1,3 @@
 // Globals are provided by lang.dart in Dart.
 // This file exists to prevent global.ts from being transpiled.
+library angular2.globals; 
diff --git a/modules/angular2/src/core/compiler/base_query_list.dart b/modules/angular2/src/core/compiler/base_query_list.dart
@@ -1,4 +1,4 @@
-library angular2.src.core.compiler.query_list;
+library angular2.src.core.compiler.base_query_list;
 
 import 'package:angular2/src/core/annotations/annotations.dart';
 import 'dart:collection';
diff --git a/modules/angular2/src/facade/browser.dart b/modules/angular2/src/facade/browser.dart
@@ -2,6 +2,7 @@
  * Dart version of browser APIs. This library depends on 'dart:html' and
  * therefore can only run in the browser.
  */
+library angular2.src.facade.browser; 
 
 import 'dart:js' show context;
 
diff --git a/modules/angular2/src/services/xhr_impl.dart b/modules/angular2/src/services/xhr_impl.dart
@@ -1,3 +1,5 @@
+library angular2.src.services.xhr_impl; 
+
 import 'dart:async';
 import 'dart:html';
 import 'package:angular2/di.dart';
diff --git a/modules/angular2/src/transform/directive_processor/rewriter.dart b/modules/angular2/src/transform/directive_processor/rewriter.dart
@@ -1,4 +1,4 @@
-library angular2.transform.directive_processor;
+library angular2.transform.directive_processor.rewriter;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/java_core.dart';
diff --git a/modules/angular2/src/transform/directive_processor/visitors.dart b/modules/angular2/src/transform/directive_processor/visitors.dart
@@ -1,4 +1,4 @@
-library angular2.transform.directive_processor;
+library angular2.transform.directive_processor.visitors;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/java_core.dart';
diff --git a/modules/angular2/test/core/compiler/view_factory_spec.js b/modules/angular2/test/core/compiler/view_factory_spec.js
@@ -17,7 +17,6 @@ import {
 import {IMPLEMENTS, isBlank} from 'angular2/src/facade/lang';
 import {ViewFactory} from 'angular2/src/core/compiler/view_factory';
 import {AppProtoView, AppView} from 'angular2/src/core/compiler/view';
-import {dynamicChangeDetection} from 'angular2/change_detection';
 import {DirectiveBinding, ElementInjector} from 'angular2/src/core/compiler/element_injector';
 import {DirectiveMetadataReader} from 'angular2/src/core/compiler/directive_metadata_reader';
 import {Component} from 'angular2/src/core/annotations/annotations';
diff --git a/modules/angular2/test/di/binding_dart_spec.dart b/modules/angular2/test/di/binding_dart_spec.dart
@@ -1,5 +1,6 @@
 /// This file contains tests that make sense only in Dart world, such as
 /// verifying that things are valid constants.
+library angular2.test.di.binding_dart_spec;
 
 import 'dart:mirrors';
 import 'package:angular2/test_lib.dart';

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`// Globals are provided by lang.dart in Dart.`
`2`	`2`	`// This file exists to prevent global.ts from being transpiled.`
	`3`	`+library angular2.globals;`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-library angular2.src.core.compiler.query_list;`
	`1`	`+library angular2.src.core.compiler.base_query_list;`
`2`	`2`
`3`	`3`	`import 'package:angular2/src/core/annotations/annotations.dart';`
`4`	`4`	`import 'dart:collection';`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+library angular2.src.services.xhr_impl;`
	`2`	`+`
`1`	`3`	`import 'dart:async';`
`2`	`4`	`import 'dart:html';`
`3`	`5`	`import 'package:angular2/di.dart';`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-library angular2.transform.directive_processor;`
	`1`	`+library angular2.transform.directive_processor.rewriter;`
`2`	`2`
`3`	`3`	`import 'package:analyzer/analyzer.dart';`
`4`	`4`	`import 'package:analyzer/src/generated/java_core.dart';`