Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

remove model parameter from @OrmLiteDao#1251

Merged
yDelouis merged 1 commit into
androidannotations:developfrom
dodgex:remove_model_from_@OrmLiteDao
May 24, 2015
Merged

remove model parameter from @OrmLiteDao#1251
yDelouis merged 1 commit into
androidannotations:developfrom
dodgex:remove_model_from_@OrmLiteDao

Conversation

@dodgex

@dodgex dodgex commented Nov 19, 2014

Copy link
Copy Markdown
Member

according to the wiki this should have been gone already. ;)

@dodgex

dodgex commented Nov 19, 2014

Copy link
Copy Markdown
Member Author

updated the wiki

@WonderCsabo

Copy link
Copy Markdown
Member

I think this is a breaking change, so we deprecated the param first. We can
only remove it actually in a major release.

@dodgex

dodgex commented Nov 19, 2014

Copy link
Copy Markdown
Member Author

well. the wiki stated that it should have been removed with 3.2. but you can keep the pr open for 4.0.

@dodgex

dodgex commented Nov 19, 2014

Copy link
Copy Markdown
Member Author

updated the wiki to 4.0 as removal release

@WonderCsabo

Copy link
Copy Markdown
Member

OK, i was in a rush when i edited the wiki, sorry. We cannot remove the param in a minor version, because it will cause compilation errors and that is a breaking change.
EDIT: The Travis build produced exactly what i am talking about. :)

@WonderCsabo WonderCsabo added this to the 4.0 milestone Nov 19, 2014
@WonderCsabo

Copy link
Copy Markdown
Member

I edited the wiki, thanks.

@dodgex

dodgex commented Nov 19, 2014

Copy link
Copy Markdown
Member Author

EDIT: The Travis build produced exactly what i am talking about. :)

yeah, for some reasons i had the test project closed in eclipse so i didnt catch that one :D

@WonderCsabo

Copy link
Copy Markdown
Member

Can you rebase this branch?

@dodgex

dodgex commented Dec 28, 2014

Copy link
Copy Markdown
Member Author

rebased.

yDelouis added a commit that referenced this pull request May 24, 2015
remove model parameter from @OrmLiteDao
@yDelouis yDelouis merged commit 8749a17 into androidannotations:develop May 24, 2015
@yDelouis

Copy link
Copy Markdown
Contributor

Thanks.

@dodgex dodgex deleted the remove_model_from_@OrmLiteDao branch May 24, 2015 13:36
@WonderCsabo

Copy link
Copy Markdown
Member

@dodgex can you update the wiki?

@dodgex

dodgex commented May 24, 2015

Copy link
Copy Markdown
Member Author

https://github.com/dodgex/androidannotations/wiki/Ormlite

i wonder if we want to deprecate helper and just use value instead (no need to write the attribute name in code).

@WonderCsabo

WonderCsabo commented May 24, 2015 via email

Copy link
Copy Markdown
Member

@yDelouis

Copy link
Copy Markdown
Contributor

I'm not sure we should rename it. It tells clearly what parameter is expected.
But if you think it's ok, go for it.

@WonderCsabo

Copy link
Copy Markdown
Member

@yDelouis i think you are right.

@WonderCsabo

Copy link
Copy Markdown
Member

@dodgex i merged your wiki changes, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants