GH-329: (android) Fixes issue: Exif data lost on many cases by AlvaroHerrero · Pull Request #331 · apache/cordova-plugin-camera

AlvaroHerrero · 2018-08-26T18:36:25Z

Platforms affected

Android

What does this PR do?

Reads the exif data from the file on these cases:
-When destType = DATA_URL
-When file is selected from gallery.
-When targetHeight or targetWidth is set, quality is not 100 or correctOrientation is true

What testing has been done on this change?

Tested on two differente android devices.

Checklist

Reported an issue in the JIRA database
Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
Added automated test coverage as appropriate for this change.

closes #329

janpio · 2018-08-27T07:42:49Z

                        // read exifData of source
                        exifData = new ExifHelper();
                        exifData.createInFile(filePath);
+                        exif.readExifData();


Where is this variable used? If this.correctOrientation is true, it is overwritten again and then used to get the orientation, but otherwise?

janpio · 2018-08-27T08:59:48Z

@@ -994,6 +994,7 @@ private Bitmap getScaledAndRotatedBitmap(String imageUrl) throws IOException {
                        // read exifData of source
                        exifData = new ExifHelper();
                        exifData.createInFile(filePath);


OT to your PR, but man is this a bad variable file. I read it as "create in file", but it actually means "create in(put)file".

janpio · 2018-08-27T09:02:49Z

                        // read exifData of source
                        exifData = new ExifHelper();
                        exifData.createInFile(filePath);
+                        exifData.readExifData();


I still don't really understand how reading some data into a property/class variable of exifData influences the further execution of code. Can you explain?

AlvaroHerrero · 2018-08-27T09:24:04Z

createInFile is the name of the function in the ExifHelper. It initializes all exif properties to null, but it is when readExifData is called when actual exif values are set.
Later, when exifData.writeExifData is called the stored values are set into the new file (rotated or whatever proccess the code does to it).
I think when the createInFile is called, it should be followed by the readExifData one, as it is done inside processResultFromCamera function.

ddsky · 2018-10-03T21:29:46Z

I have tested this and it works as intended. Voting for a pull of this fix.

janpio · 2018-10-03T21:45:49Z

(@ddsky You should be able to leave an actual "Approve" review in the "Files changed" tab - that will make it easier for us to spot the positive review. Thanks!)

ddsky

Worked for me

j3k0

Works for me and saved my day!

ddsky · 2018-10-29T12:41:17Z

any news on when this will be merged?

janpio · 2018-10-30T14:43:45Z

You will learn about it here by an update to the PR being posted by GitHub. (If I am involved, it will now happen 2 minutes later as I had to open this notification, read your message and reply.)

BorntraegerMarc · 2019-02-20T19:10:16Z

Can I help in anyway to get this PR merged? It has been quite some time and it seems like everything is ok 🙂

BorntraegerMarc · 2019-02-21T17:35:50Z

thanks all for merging! Could someone tell me when the next version release is planned? 🙂

janpio · 2019-02-21T18:15:37Z

No, as there is not ETA for releases. Someone from the committer team will have to take the time to prepare the release (which means understanding all the PRs merged, giving them another round of testing, doing the actual release. this time probably also updating CI configuration as the last release was some time ago and new OS versions were released - which of course also have to be tested.)

mirko77 · 2019-03-07T11:21:25Z

Exif metadata are not saved on iOS either (iOS 12) with the following settings:

camera_options={
  quality: 50,
  sourceType: source_type,
  destinationType: Camera.DestinationType.FILE_URI,
  targetWidth: 1024,
  targetHeight: 1024,
  encodingType: Camera.EncodingType.JPEG,
  correctOrientation: true
};

Is this issue related?

AlvaroHerrero · 2019-03-07T11:23:35Z

It should not. I just fixed the Java code for Android.

mirko77 · 2019-03-07T11:34:01Z

I will have to open another issue then, could not find any existing one about EXIF data missing on iOS.
Works fine on Android though, and I do not have the PR in my code. Weird

BorntraegerMarc · 2019-03-07T14:37:00Z

@mirko77 EXIF data is working fine for us on iOS 12

mirko77 · 2019-03-07T15:23:11Z

@mirko77 EXIF data is working fine for us on iOS 12

@BorntraegerMarc I cannot figure it out. Even if I take a picture with the camera app and send it to me via Gmail, the image does not have any EXIF metadata in it. Any suggestions?

chintan13 · 2019-03-11T10:27:21Z

I am also facing this issue. let me once you create special issue for it, so I can also follow progress on it.

mirko77 · 2019-03-11T10:28:43Z

I am also facing this issue. let me once you create special issue for it, so I can also follow progress on it.

Do you mean you cannot get the EXIF data in iOS as well?

dlydiard · 2019-03-11T20:39:53Z

i also do not get EXIF data on iOS when using the camera with:
{
quality: 85,
sourceType: Camera.PictureSourceType.CAMERA,
mediaType: Camera.MediaType.PICTURE,
allowEdit: false,
correctOrientation: true
}

chintan13 · 2019-03-19T16:35:36Z

Yes in case of IOS HEIC image format
sourceType = this.camera.PictureSourceType.PHOTOLIBRARY;
destinationType = this.camera.DestinationType.FILE_URI

We are loosing metadata from image.

mirko77 · 2019-03-19T16:56:27Z

Has this issue been reported yet? @chintan13 @dlydiard

chintan13 · 2019-03-19T20:00:37Z

no but there is open pr from last two years,
I suspect now that code might be much outdated.

janpio · 2019-06-19T19:50:35Z

Please open an issue @chintan13 and link to the PR - this will greatly improve the chance that the PR gets merged.

ryaa · 2019-11-10T11:54:09Z

Has this issue been reported yet? @chintan13 @dlydiard

I added an issue for the problem with EXIF on iOS (see #524) and provided a potential fix (see #525)

apacheGH-329 android: Fix Exif data lost when correctOrientation is true

7bf22af

AlvaroHerrero changed the title ~~GH-329: (android) Fixes issue: Exif data lost on differente cases~~ GH-329: (android) Fixes issue: Exif data lost on many cases Aug 26, 2018

janpio reviewed Aug 27, 2018

View reviewed changes

Changed variable name

beab392

janpio reviewed Aug 27, 2018

View reviewed changes

AlvaroHerrero mentioned this pull request Sep 13, 2018

Exif data lost when correctOrientation is true #329

Closed

janpio added platform: android bug enhancement labels Sep 16, 2018

ddsky approved these changes Oct 3, 2018

View reviewed changes

j3k0 approved these changes Oct 29, 2018

View reviewed changes

j3k0 mentioned this pull request Oct 30, 2018

Cordova camera doesn't rotate the pic to correct orientation on Samsung phones #354

Open

janpio merged commit 81b878d into apache:master Feb 21, 2019

Uh oh!

Conversation

AlvaroHerrero commented Aug 26, 2018 • edited by janpio Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

Uh oh!

janpio Aug 27, 2018

Choose a reason for hiding this comment

Uh oh!

janpio Aug 27, 2018

Choose a reason for hiding this comment

Uh oh!

janpio Aug 27, 2018

Choose a reason for hiding this comment

Uh oh!

AlvaroHerrero commented Aug 27, 2018

Uh oh!

ddsky commented Oct 3, 2018

Uh oh!

janpio commented Oct 3, 2018

Uh oh!

ddsky left a comment

Choose a reason for hiding this comment

Uh oh!

j3k0 left a comment

Choose a reason for hiding this comment

Uh oh!

ddsky commented Oct 29, 2018

Uh oh!

janpio commented Oct 30, 2018

Uh oh!

BorntraegerMarc commented Feb 20, 2019

Uh oh!

BorntraegerMarc commented Feb 21, 2019

Uh oh!

janpio commented Feb 21, 2019

Uh oh!

mirko77 commented Mar 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlvaroHerrero commented Mar 7, 2019

Uh oh!

mirko77 commented Mar 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BorntraegerMarc commented Mar 7, 2019

Uh oh!

mirko77 commented Mar 7, 2019

Uh oh!

chintan13 commented Mar 11, 2019

Uh oh!

mirko77 commented Mar 11, 2019

Uh oh!

dlydiard commented Mar 11, 2019

Uh oh!

chintan13 commented Mar 19, 2019

Uh oh!

mirko77 commented Mar 19, 2019

Uh oh!

chintan13 commented Mar 19, 2019

Uh oh!

janpio commented Jun 19, 2019

Uh oh!

ryaa commented Nov 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

AlvaroHerrero commented Aug 26, 2018 •

edited by janpio

Loading

mirko77 commented Mar 7, 2019 •

edited

Loading

mirko77 commented Mar 7, 2019 •

edited

Loading