Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: approvals/ApprovalTests.Python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: approvals/ApprovalTests.Python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: reference-for-date-scrubber
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 13 files changed
  • 10 contributors

Commits on Jul 20, 2025

  1. *** work in progress 

    Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com>
Co-Authored-By: Llewellyn Falco <llewellyn.falco@gmail.com>
Co-Authored-By: Matt Anderson <matthew.anderson11@gmail.com>
Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>
Co-Authored-By: jmasonlee <262853+jmasonlee@users.noreply.github.com>
Co-Authored-By: Lada Kesseler <23501754+lexler@users.noreply.github.com>
    @JayBazuzi @susanfung
    @isidore @mander11 @nitsanavni @jmasonlee @lexler
    7 people committed Jul 20, 2025
    Configuration menu
    Copy the full SHA
    a19eb05 View commit details
    Browse the repository at this point in the history

  2. - F Created DateScrubber.add_crubber(example, regex) 

    Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com>
Co-Authored-By: Llewellyn Falco <llewellyn.falco@gmail.com>
Co-Authored-By: Matt Anderson <matthew.anderson11@gmail.com>
Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>
Co-Authored-By: jmasonlee <262853+jmasonlee@users.noreply.github.com>
Co-Authored-By: Lada Kesseler <23501754+lexler@users.noreply.github.com>
    @JayBazuzi @susanfung
    @isidore @mander11 @nitsanavni @jmasonlee @lexler
    7 people committed Jul 20, 2025
    Configuration menu
    Copy the full SHA
    0e8201b View commit details
    Browse the repository at this point in the history

  3. . t Added test for incorrect regex 

    Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com>
Co-Authored-By: Llewellyn Falco <llewellyn.falco@gmail.com>
Co-Authored-By: Matt Anderson <matthew.anderson11@gmail.com>
Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>
Co-Authored-By: jmasonlee <262853+jmasonlee@users.noreply.github.com>
Co-Authored-By: Lada Kesseler <23501754+lexler@users.noreply.github.com>
    @JayBazuzi @susanfung
    @isidore @mander11 @nitsanavni @jmasonlee @lexler
    7 people committed Jul 20, 2025
    Configuration menu
    Copy the full SHA
    0d1333d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2025

  1. . d Add Discord Invite Link 

    Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Joss Hufnagel <43077216+blade290@users.noreply.github.com>
Co-Authored-By: geekacts2526 <41352629+geekacts2526@users.noreply.github.com>
    @JayBazuzi @4dsherwood
    @blade290 @geekacts2526
    4 people committed Jul 27, 2025
    Configuration menu
    Copy the full SHA
    11721a9 View commit details
    Browse the repository at this point in the history

  2. . t reformatted source to fit in IDE 105-110 

    Cascade also made edits to make the test_handles_invalid_regex_patterns_gracefully() pass

Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Joss Hufnagel <43077216+blade290@users.noreply.github.com>
Co-Authored-By: geekacts2526 <41352629+geekacts2526@users.noreply.github.com>
    @JayBazuzi @4dsherwood
    @blade290 @geekacts2526
    4 people committed Jul 27, 2025
    Configuration menu
    Copy the full SHA
    e59caaf View commit details
    Browse the repository at this point in the history

  3. . d Improved error message and clarified todo list at bottom 

    Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Joss Hufnagel <43077216+blade290@users.noreply.github.com>
Co-Authored-By: geekacts2526 <41352629+geekacts2526@users.noreply.github.com>
    @JayBazuzi @4dsherwood
    @blade290 @geekacts2526
    4 people committed Jul 27, 2025
    Configuration menu
    Copy the full SHA
    f7a0d1d View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2025

  1. . t added MANY draft error messages for unsupported date formats 

     improve error messages for unsupported date formats
- switched to using [ x ] for Done
- added a BUNCH of potential error messages
NOTE commit earlier in the day may not have included: @digable1

Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
    @JayBazuzi @4dsherwood
    JayBazuzi and 4dsherwood committed Jul 28, 2025
    Configuration menu
    Copy the full SHA
    47b6c62 View commit details
    Browse the repository at this point in the history

  2. . d mentioned location of the 7/20& 7/27 todo list 

    see detailed todo in test_date_scrubber.test_unsupported_format.approved.txt

Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
    @JayBazuzi @4dsherwood
    JayBazuzi and 4dsherwood committed Jul 28, 2025
    Configuration menu
    Copy the full SHA
    8f99400 View commit details
    Browse the repository at this point in the history

  3. . d how to add_scrubber 

    docs: add documentation for date scrubbing and custom scrubber support
Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
    @JayBazuzi @4dsherwood
    JayBazuzi and 4dsherwood committed Jul 28, 2025
    Configuration menu
    Copy the full SHA
    5bf3e37 View commit details
    Browse the repository at this point in the history

  4. ! t moving todo into TODO.md 

    not all the files are working together (oops!)

Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
    @JayBazuzi @4dsherwood
    JayBazuzi and 4dsherwood committed Jul 28, 2025
    Configuration menu
    Copy the full SHA
    1e79583 View commit details
    Browse the repository at this point in the history

  5. docs: add documentation for date scrubbing and custom scrubber support

    @JayBazuzi
    JayBazuzi committed Jul 28, 2025
    Configuration menu
    Copy the full SHA
    9328846 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2025

  1. *** 

    Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Joss Hufnagel <43077216+blade290@users.noreply.github.com>
Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>
    @JayBazuzi @4dsherwood
    @blade290 @nitsanavni
    4 people committed Aug 3, 2025
    Configuration menu
    Copy the full SHA
    5b96c9f View commit details
    Browse the repository at this point in the history
Loading