-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: rschmitt/aws-lambda-java-libs
base: main
head repository: aws/aws-lambda-java-libs
compare: main
- 10 commits
- 13 files changed
- 5 contributors
Commits on May 23, 2026
-
test(log4j2): Add initial test suite covering plugin registration (aw…
…s#615) This package previously had no tests and no JUnit dependency. Add JUnit Jupiter, the surefire plugin, and an initial test class that exercises the full plugin resolution path end-to-end: a log4j2.xml on the test classpath, a real LogManager-issued logger, and stdout capture (LambdaAppender writes through LambdaRuntime.getLogger() to System.out). The TEXT test routes the root logger through LambdaTextFormat with a deterministic PatternLayout and asserts each level appears. The JSON test adds a second LambdaAppender with format="JSON" backed by JsonTemplateLayout + LambdaLayout.json, attached via additivity=false to a "json-test" logger, and asserts the messages show up JSON-encoded. Add log4j-layout-template-json at test scope so the JSON path can resolve at test time. Users are still expected to bring their own copy at runtime (peer-dependency model, like PatternLayout); the published artifact's dependency surface is unchanged. The tests succeed on Java 8 and fail on Java 25, because annotation processors are not run by default on Java 25, Log4j2Plugins.dat is not generated for our plugins, and both tests surface the resulting CLASS_NOT_FOUND from the log4j status logger.
Configuration menu - View commit details
-
Copy full SHA for 2714c2c - Browse repository at this point
Copy the full SHA 2714c2cView commit details -
build(log4j2): Pin compilation to JDK 8 via Maven Toolchains (aws#616)
Release 1.6.3 was built on a JDK that does not run annotation processors by default, which silently dropped the Log4j2 plugin descriptor (META-INF/.../Log4j2Plugins.dat) for LambdaAppender, LambdaTextFormat, and LambdaJsonFormat. The published artifact was broken at runtime: log4j could not resolve <Lambda>, <LambdaTextFormat>, or <LambdaJsonFormat> elements in user log4j2.xml configurations. Configure maven-toolchains-plugin to require a JDK 8 toolchain so javac comes from a JDK that runs annotation processors by default, regardless of which JVM Maven is invoked under. The version range [1.8,9) matches both "1.8" and "8". The existing GitHub Actions workflow at .github/workflows/aws-lambda-java-log4j2.yml uses actions/setup-java@v5 with java-version: 8 and distribution: corretto. setup-java@v5 auto-generates a ~/.m2/toolchains.xml entry with <version>8</version>, which the [1.8,9) range matches, so no workflow changes are required. When no matching JDK 8 toolchain is available, the build now fails fast at the validate phase with a clear "Cannot find matching toolchain definitions" error instead of silently producing an artifact missing its plugin descriptor. Co-authored-by: Davide Melfi <darklight3it@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0abf6d7 - Browse repository at this point
Copy the full SHA 0abf6d7View commit details
Commits on May 29, 2026
-
Update README.md to add note re v1.6.3 regression (aws#618)
Added note regarding v1.6.3.
Configuration menu - View commit details
-
Copy full SHA for cfefd3b - Browse repository at this point
Copy the full SHA cfefd3bView commit details
Commits on Jun 29, 2026
-
Add end-to-end integration tests
Fabiana Severin committedJun 29, 2026 Configuration menu - View commit details
-
Copy full SHA for 845ae2a - Browse repository at this point
Copy the full SHA 845ae2aView commit details
Commits on Jun 30, 2026
-
Pin GitHub Actions to commit SHAs
Fabiana Severin committedJun 30, 2026 Configuration menu - View commit details
-
Copy full SHA for 76ec4ed - Browse repository at this point
Copy the full SHA 76ec4edView commit details
Commits on Jul 1, 2026
-
fix: run integ test on both architectures
Fabiana Severin committedJul 1, 2026 Configuration menu - View commit details
-
Copy full SHA for 9610b52 - Browse repository at this point
Copy the full SHA 9610b52View commit details -
fix: changing to precreated bucket
Fabiana Severin committedJul 1, 2026 Configuration menu - View commit details
-
Copy full SHA for 0e35558 - Browse repository at this point
Copy the full SHA 0e35558View commit details -
Fabiana Severin committed
Jul 1, 2026 Configuration menu - View commit details
-
Copy full SHA for cb9c4f6 - Browse repository at this point
Copy the full SHA cb9c4f6View commit details
Commits on Jul 2, 2026
-
fix: use architecture-aware JAVA_HOME on matrix runners
Fabiana Severin committedJul 2, 2026 Configuration menu - View commit details
-
Copy full SHA for 361bbfc - Browse repository at this point
Copy the full SHA 361bbfcView commit details -
Merge pull request aws#619 from aws/fabisev/integration-tests
Add end-to-end integration tests
Configuration menu - View commit details
-
Copy full SHA for 9b4df8f - Browse repository at this point
Copy the full SHA 9b4df8fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...main