CLOUDSTACK-1871 : domainId parameter to uploadVolume not working

isaacchiang · isaacchiang · commit 63e92a4ea676 · 2013-05-20T08:54:13.000+08:00
1. Remove duplicated lines for setting domainId.
2. Set domainId with owner's domain if the owner is specified.
diff --git a/server/src/com/cloud/storage/VolumeManagerImpl.java b/server/src/com/cloud/storage/VolumeManagerImpl.java
@@ -708,19 +708,19 @@ private VolumeVO persistVolume(Account caller, long ownerId, Long zoneId,
 
         VolumeVO volume = new VolumeVO(volumeName, zoneId, -1, -1, -1,
                 new Long(-1), null, null, 0, Volume.Type.DATADISK);
+        Account owner = (caller.getId() == ownerId) ? caller : _accountMgr
+                          .getActiveAccountById(ownerId);
         volume.setPoolId(null);
         volume.setDataCenterId(zoneId);
         volume.setPodId(null);
         volume.setAccountId(ownerId);
-        volume.setDomainId(((caller == null) ? Domain.ROOT_DOMAIN : caller
-                .getDomainId()));
         long diskOfferingId = _diskOfferingDao.findByUniqueName(
                 "Cloud.com-Custom").getId();
         volume.setDiskOfferingId(diskOfferingId);
         // volume.setSize(size);
         volume.setInstanceId(null);
         volume.setUpdated(new Date());
-        volume.setDomainId((caller == null) ? Domain.ROOT_DOMAIN : caller
+        volume.setDomainId((owner == null) ? Domain.ROOT_DOMAIN : owner
                 .getDomainId());
 
         volume = _volsDao.persist(volume);
