Multiple test improvements

tkislan · tkislan · commit 3bedeb00948a · 2026-03-26T12:31:40.000Z
diff --git a/packages/cli/src/commands/integrations/tests/add-integration.clickhouse.test.ts b/packages/cli/src/commands/integrations/tests/add-integration.clickhouse.test.ts
@@ -1,4 +1,5 @@
 import crypto from 'node:crypto'
+import { existsSync } from 'node:fs'
 import { mkdir, readFile, rm } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
@@ -142,6 +143,8 @@ describe('add-integration clickhouse', () => {
             user: ch-user
       "
     `)
+
+    expect(existsSync(envFilePath)).toBe(false)
   })
 
   it('creates clickhouse integration with SSH tunnel enabled', async () => {
diff --git a/packages/cli/src/commands/integrations/tests/add-integration.mindsdb.test.ts b/packages/cli/src/commands/integrations/tests/add-integration.mindsdb.test.ts
@@ -179,7 +179,7 @@ describe('add-integration mindsdb', () => {
     `)
   })
 
-  it('creates integration with SSL enabled', async () => {
+  it('creates mindsdb integration with SSL enabled', async () => {
     const filePath = join(tempDir, 'integrations-ssl.yaml')
     const envFilePath = join(tempDir, '.env')
     const mockUUID: crypto.UUID = 'aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee'
diff --git a/packages/cli/src/commands/integrations/tests/add-integration.mysql.test.ts b/packages/cli/src/commands/integrations/tests/add-integration.mysql.test.ts
@@ -179,7 +179,7 @@ describe('add-integration mysql', () => {
     `)
   })
 
-  it('creates integration with SSL enabled', async () => {
+  it('creates mysql integration with SSL enabled', async () => {
     const filePath = join(tempDir, 'integrations-ssl.yaml')
     const envFilePath = join(tempDir, '.env')
     const mockUUID: crypto.UUID = 'aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee'
@@ -204,14 +204,12 @@ describe('add-integration mysql', () => {
 
     await screen.next()
     expect(screen.getScreen()).toContain('CA Certificate:')
-    screen.type('cert-content-here')
+    screen.type('placeholder')
     screen.keypress('enter')
 
     await promise
 
     const yamlContent = await readFile(filePath, 'utf-8')
-    const envContent = await readFile(envFilePath, 'utf-8')
-
     expect(yamlContent).toMatchInlineSnapshot(`
       "#yaml-language-server: $schema=https://raw.githubusercontent.com/deepnote/deepnote/refs/heads/tk/integrations-config-file-schema/json-schemas/integrations-file-schema.json
 
@@ -230,10 +228,18 @@ describe('add-integration mysql', () => {
             caCertificateText: env:AAAAAAAA_BBBB_CCCC_DDDD_EEEEEEEEEEEE__CACERTIFICATETEXT
       "
     `)
-    expect(envContent).toMatchInlineSnapshot(`
-      "AAAAAAAA_BBBB_CCCC_DDDD_EEEEEEEEEEEE__PASSWORD=supersecret
-      AAAAAAAA_BBBB_CCCC_DDDD_EEEEEEEEEEEE__CACERTIFICATETEXT=cert-content-here
-      "
-    `)
+
+    // Verify multiline values survive the updateDotEnv → readDotEnv roundtrip.
+    // screen.type() cannot inject literal newlines (they act as Enter/submit),
+    // so we write a multiline cert value directly and verify it parses back.
+    const { updateDotEnv, readDotEnv } = await import('../../../utils/dotenv')
+    const multilineCert = 'line-1-of-cert\nline-2-of-cert\nline-3-of-cert'
+    await updateDotEnv(envFilePath, {
+      AAAAAAAA_BBBB_CCCC_DDDD_EEEEEEEEEEEE__CACERTIFICATETEXT: multilineCert,
+    })
+
+    const parsedEnv = await readDotEnv(envFilePath)
+    expect(parsedEnv.AAAAAAAA_BBBB_CCCC_DDDD_EEEEEEEEEEEE__PASSWORD).toBe('supersecret')
+    expect(parsedEnv.AAAAAAAA_BBBB_CCCC_DDDD_EEEEEEEEEEEE__CACERTIFICATETEXT).toBe(multilineCert)
   })
 })
diff --git a/packages/cli/src/commands/integrations/tests/add-integration.pgsql.test.ts b/packages/cli/src/commands/integrations/tests/add-integration.pgsql.test.ts
@@ -152,6 +152,7 @@ describe('add-integration pgsql', () => {
     await promise
 
     const yamlContent = await readFile(filePath, 'utf-8')
+    const envContent = await readFile(envFilePath, 'utf-8')
 
     expect(yamlContent).toMatchInlineSnapshot(`
       "#yaml-language-server: $schema=https://raw.githubusercontent.com/deepnote/deepnote/refs/heads/tk/integrations-config-file-schema/json-schemas/integrations-file-schema.json
@@ -173,6 +174,10 @@ describe('add-integration pgsql', () => {
             password: env:NEW_UUID_1234_5678_ABCD1234ABCD__PASSWORD
       "
     `)
+    expect(envContent).toMatchInlineSnapshot(`
+      "NEW_UUID_1234_5678_ABCD1234ABCD__PASSWORD=new-pass
+      "
+    `)
   })
 
   it('creates integration with SSH tunnel enabled', async () => {
diff --git a/packages/cli/src/commands/integrations/tests/add-integration.sql-server.test.ts b/packages/cli/src/commands/integrations/tests/add-integration.sql-server.test.ts
@@ -146,6 +146,8 @@ describe('add-integration sql-server', () => {
     await promise
 
     const yamlContent = await readFile(filePath, 'utf-8')
+    const envContent = await readFile(envFilePath, 'utf-8')
+
     expect(yamlContent).toMatchInlineSnapshot(`
       "#yaml-language-server: $schema=https://raw.githubusercontent.com/deepnote/deepnote/refs/heads/tk/integrations-config-file-schema/json-schemas/integrations-file-schema.json
 
@@ -165,5 +167,9 @@ describe('add-integration sql-server', () => {
             sshUser: tunnel-user
       "
     `)
+    expect(envContent).toMatchInlineSnapshot(`
+      "AAAAAAAA_BBBB_CCCC_DDDD_EEEEEEEEEEEE__PASSWORD=supersecret
+      "
+    `)
   })
 })
diff --git a/packages/cli/src/commands/integrations/tests/edit-integration.sql-server.test.ts b/packages/cli/src/commands/integrations/tests/edit-integration.sql-server.test.ts
@@ -98,6 +98,12 @@ integrations:
             password: env:ID001__PASSWORD
       "
     `)
+
+    const envContent = await readFile(envFilePath, 'utf-8')
+    expect(envContent).toMatchInlineSnapshot(`
+      "ID001__PASSWORD=secret-pass
+      "
+    `)
   })
 
   it('updates host and database when user types new values', async () => {
