refactor: remove useless assignemnt

AnneYang720 · AnneYang720 · commit a10a66fe00e6 · 2023-03-28T11:42:04.000+08:00
Signed-off-by: AnneY &lt;evangeline-lun@foxmail.com&gt;
diff --git a/docarray/index/abstract.py b/docarray/index/abstract.py
@@ -854,13 +854,9 @@ def _convert_dict_to_doc(
         :return: A Document object
         """
         for field_name, _ in schema.__fields__.items():
-            t_ = schema._get_field_type(field_name)
-            if is_tensor_union(t_):
-                t_ = AbstractTensor
-            else:
-                t_ = unwrap_optional_type(t_)
+            t_ = unwrap_optional_type(schema._get_field_type(field_name))
 
-            if issubclass(t_, BaseDocument):
+            if not is_union_type(t_) and issubclass(t_, BaseDocument):
                 inner_dict = {}
 
                 fields = [
diff --git a/tests/index/base_classes/test_base_doc_store.py b/tests/index/base_classes/test_base_doc_store.py
@@ -342,7 +342,6 @@ class OtherNestedDoc(NestedDoc):
         )
 
 
-# TODO change here
 def test_docs_validation_unions():
     class OptionalDoc(BaseDocument):
         tens: Optional[NdArray[10]] = Field(dim=1000)

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,6 @@ class OtherNestedDoc(NestedDoc):`
`342`	`342`	`)`
`343`	`343`
`344`	`344`
`345`		`-# TODO change here`
`346`	`345`	`def test_docs_validation_unions():`
`347`	`346`	`class OptionalDoc(BaseDocument):`
`348`	`347`	`tens: Optional[NdArray[10]] = Field(dim=1000)`